[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8436: packaging script adjustments

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8436: packaging script adjustments
URL: https://github.com/apache/incubator-druid/pull/8436#discussion_r319359173
 
 

 ##########
 File path: distribution/bin/generate-binary-notice.py
 ##########
 @@ -81,11 +80,11 @@ def generate_notice(source_notice, dependences_yaml):
         parser.add_argument('out_path', metavar='<path to output file>', type=str)
         args = parser.parse_args()
 
-        with open(args.notice) as apache_notice_file:
+        with open(args.notice, encoding="ascii") as apache_notice_file:
 
 Review comment:
   No, that is just how it was encoded originally I guess:
   ```
   $ file -I licenses.yaml 
   licenses.yaml: text/plain; charset=utf-8
   
   $ file -I LICENSE
   LICENSE: text/plain; charset=us-ascii
   
   $ file -I NOTICE
   NOTICE: text/plain; charset=us-ascii
   
   $ file -I licenses/APACHE2 
   licenses/APACHE2: text/plain; charset=us-ascii
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org