You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "poorbarcode (via GitHub)" <gi...@apache.org> on 2026/09/07 04:11:11 UTC

[PR] [fix][broker]Incorrect source side topic permission deletion when disabling replication [pulsar]

poorbarcode opened a new pull request, #26479:
URL: https://github.com/apache/pulsar/pull/26479

   ### Motivation
   
   **Env**
   - two clsuters `[c1, c2]` with shared metadata store
   
   **Issue**
   - disabled replication by set topic level replication `[c1]`
     - then `c2` can not access the topic anymore
   - Issue: `c1` cluster topic permission configuration was deleted 
   
   ### Modifications
   
   fix the issue
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][broker]Incorrect source side topic permission deletion when disabling replication [pulsar]

Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #26479:
URL: https://github.com/apache/pulsar/pull/26479#issuecomment-6145921486

   @void-ptr974 
   
   > checkAllowedCluster() also returns false for ordinary non-replicated namespaces, where both the effective replication clusters and allowed_clusters are empty. Normal topic deletion therefore skips authentication cleanup. The topic ACL remains in metadata and may be applied again if a topic with the same name is recreated. This path also causes the current PersistentTopicTest.testDeleteTopicDeleteOnMetadataStoreFailed CI failure, because topic.delete() succeeds after bypassing the expected permission-removal failure.
   
   The replication cluster at the namespace level will never be empty
   
   > When getPoliciesAsync() completes exceptionally, the thenAccept callback is not invoked and its returned stage is ignored. deleteTopicAuthenticationFuture consequently never completes. The public deletion future can then remain pending indefinitely after the topic has been fenced, leaving the topic unavailable until external recovery.
   
   The error you mentioned has bee covered here https://github.com/apache/pulsar/pull/26479/changes#diff-5edf14cc6f25857d0cfdd26b2d3b3141230ecfb0dfa95aebf7583fd76ede4c4bR1694


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][broker]Incorrect source side topic permission deletion when disabling replication [pulsar]

Posted by "void-ptr974 (via GitHub)" <gi...@apache.org>.
void-ptr974 commented on PR #26479:
URL: https://github.com/apache/pulsar/pull/26479#issuecomment-5586011906

   Thanks for addressing the shared topic-permission issue during cluster-removal cleanup. The added test covers the intended scenario well. I noticed two additional cases introduced by the new asynchronous check:
   
   1. `checkAllowedCluster()` also returns `false` for ordinary non-replicated namespaces, where both the effective replication clusters and `allowed_clusters` are empty. Normal topic deletion therefore skips authentication cleanup. The topic ACL remains in metadata and may be applied again if a topic with the same name is recreated. This path also causes the current `PersistentTopicTest.testDeleteTopicDeleteOnMetadataStoreFailed` CI failure, because `topic.delete()` succeeds after bypassing the expected permission-removal failure.
   
   2. When `getPoliciesAsync()` completes exceptionally, the `thenAccept` callback is not invoked and its returned stage is ignored. `deleteTopicAuthenticationFuture` consequently never completes. The public deletion future can then remain pending indefinitely after the topic has been fenced, leaving the topic unavailable until external recovery.
   
   Both cases affect deletion behavior outside the successful cluster-removal scenario covered by the new test and should be addressed before merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][broker]Incorrect source side topic permission deletion when disabling replication [pulsar]

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #26479:
URL: https://github.com/apache/pulsar/pull/26479


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org