You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/07/19 11:08:35 UTC

[GitHub] [spark] panbingkun opened a new pull request, #42073: [SPARK-44482][CONNECT] Connect server should can specify the bind address

panbingkun opened a new pull request, #42073:
URL: https://github.com/apache/spark/pull/42073

   ### What changes were proposed in this pull request?
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   ### How was this patch tested?
   - Manually test.
   - Pass GA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #42073: [SPARK-44482][CONNECT] Connect server should can specify the bind address

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42073: [SPARK-44482][CONNECT] Connect server should can specify the bind address
URL: https://github.com/apache/spark/pull/42073


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42073: [SPARK-44482][CONNECT] Connect server should can specify the bind address

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42073:
URL: https://github.com/apache/spark/pull/42073#issuecomment-1653072432

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] panbingkun commented on pull request #42073: [SPARK-44482][CONNECT] Connect server should can specify the bind address

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42073:
URL: https://github.com/apache/spark/pull/42073#issuecomment-1653053681

   @HyukjinKwon The GA finally turned green. 😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] panbingkun commented on pull request #42073: [SPARK-44482][CONNECT] Connect server should can specify the bind address

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42073:
URL: https://github.com/apache/spark/pull/42073#issuecomment-1641909732

   The manual testing process is as follows:
   1.My local env as follows:
   172.xxx.xxx.xxx
   
   2.Set the following configuration in `spark-defauls.conf`
   - spark.connect.grpc.binding.address 127.0.0.1
   - spark.connect.grpc.binding.port 5000`
   
   3.Start connect server
   sh sbin/stop-connect-server.sh
   
   4.Specify the host name and port to connect to the server
   - Success Scenario:
     <img width="930" alt="image" src="https://github.com/apache/spark/assets/15246973/01e2b7ce-5e1c-4c3b-b321-e97df43b8a26">
   
   - Failure scenario:
   <img width="956" alt="image" src="https://github.com/apache/spark/assets/15246973/d7de08dc-ac46-4e45-98ca-2d54646fbdbb">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org