You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/12 10:04:26 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #27547: [SPARK-30759][SQL][TESTS][FOLLOWUP] Check cache initialization in StringRegexExpression

cloud-fan commented on a change in pull request #27547: [SPARK-30759][SQL][TESTS][FOLLOWUP] Check cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27547#discussion_r378149997
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala
 ##########
 @@ -329,4 +329,12 @@ class RegexpExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
     checkEvaluation(StringSplit(s1, s2, -1), null, row3)
   }
 
+  test("cache initialization for literal patterns") {
 
 Review comment:
   can we include the JIRA number?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org