[GitHub] [kylin] liuzhao-lz opened a new pull request, #2005: KYLIN-5277 MetadataCleanupJob.isJobComplete should include NSparkMerg…

[GitBox <gi...@apache.org>]

liuzhao-lz opened a new pull request, #2005:
URL: https://github.com/apache/kylin/pull/2005

   …ingJob
   
   ## Proposed changes
   
   The running data generated by kylin4 mergeCubeJob also needs to be cleaned.
   
   ## Branch to commit
   - [ ] Branch **kylin3** for v2.x to v3.x
   - [x] Branch **kylin4** for v4.x
   - [ ] Branch **kylin5** for v5.x
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [x] I have added tests that prove my fix is effective or that my feature works
   - [ ] I have added necessary documentation (if appropriate)
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at user@kylin.apache.org or dev@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] liuzhao-lz commented on pull request #2005: KYLIN-5277 MetadataCleanupJob.isJobComplete should include NSparkMerg…

[GitBox <gi...@apache.org>]

liuzhao-lz commented on PR #2005:
URL: https://github.com/apache/kylin/pull/2005#issuecomment-1345896607

   The log data generated by kylin4 'NSparkMergingJob' should also be deleted, not just the 'NSparkCubingJob' log data.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus commented on pull request #2005: KYLIN-5277 MetadataCleanupJob.isJobComplete should include NSparkMerg…

[GitBox <gi...@apache.org>]

hit-lacus commented on PR #2005:
URL: https://github.com/apache/kylin/pull/2005#issuecomment-1296193349

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org