[GitHub] [helix] qqu0127 commented on a diff in pull request #2190: Remove cloud config check in VirtualTopologyGroupService

[GitBox <gi...@apache.org>]

qqu0127 commented on code in PR #2190:
URL: https://github.com/apache/helix/pull/2190#discussion_r943965565


##########
helix-rest/src/main/java/org/apache/helix/rest/server/service/VirtualTopologyGroupService.java:
##########
@@ -89,11 +89,6 @@ public VirtualTopologyGroupService(HelixAdmin helixAdmin, ClusterService cluster
    */
   public void addVirtualTopologyGroup(String clusterName, Map<String, String> customFields) {
     // validation
-    CloudConfig cloudConfig = _configAccessor.getCloudConfig(clusterName);

Review Comment:
   It's totally fine to run in cloud environment. It doesn't matter whether its null or not. CloudConfig isn't used anywhere else after the validation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org