You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/08 23:12:53 UTC

[GitHub] [superset] ktmud opened a new issue #12366: [Cosmetic][Explore] "Add to dashboard" dropdown should have a placeholder

ktmud opened a new issue #12366:
URL: https://github.com/apache/superset/issues/12366


   ## Screenshot
   
   <img src="https://user-images.githubusercontent.com/335541/104073894-b578d680-51c3-11eb-81c3-d2714db4bef6.png" width="600">
   
   ## Description
   
   Two small cosmetic issues:
   
   1. This dropdown should have a placeholder. 
   2. The clear button (x) should hide when there is no value selected.
   
   ## Design input
   [describe any input/collaboration you'd like from designers, and
   tag accordingly. For design review, add the
   label `design:review`. If this includes a design proposal,
   include the label `design:suggest`]
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] mihir174 commented on issue #12366: [Cosmetic][Explore] "Add to dashboard" dropdown should have a placeholder

Posted by GitBox <gi...@apache.org>.
mihir174 commented on issue #12366:
URL: https://github.com/apache/superset/issues/12366#issuecomment-757053329


   ![Base Layout](https://user-images.githubusercontent.com/64227069/104076101-d7755780-51c9-11eb-8c00-d040d6649cb3.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12366: [Cosmetic][Explore] "Add to dashboard" dropdown should have a placeholder

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12366:
URL: https://github.com/apache/superset/issues/12366#issuecomment-766173102


   confirmed issue has been resolved. Thank you @nikolagigic! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc closed issue #12366: [Cosmetic][Explore] "Add to dashboard" dropdown should have a placeholder

Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12366:
URL: https://github.com/apache/superset/issues/12366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] mihir174 commented on issue #12366: [Cosmetic][Explore] "Add to dashboard" dropdown should have a placeholder

Posted by GitBox <gi...@apache.org>.
mihir174 commented on issue #12366:
URL: https://github.com/apache/superset/issues/12366#issuecomment-757053329


   ![Base Layout](https://user-images.githubusercontent.com/64227069/104076101-d7755780-51c9-11eb-8c00-d040d6649cb3.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org