You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2017/09/08 00:43:28 UTC
Review Request 62180: refactor away GemfireCacheImpl.getInstance from
lucene function
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62180/
-----------------------------------------------------------
Review request for geode, Barry Oglesby and Dan Smith.
Bugs: GEODE-3557
https://issues.apache.org/jira/browse/GEODE-3557
Repository: geode
Description
-------
use dm.getCache() instead
Diffs
-----
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/DestroyLuceneIndexMessage.java 9eada5b20
Diff: https://reviews.apache.org/r/62180/diff/1/
Testing
-------
Thanks,
xiaojian zhou
Re: Review Request 62180: refactor away GemfireCacheImpl.getInstance
from lucene function
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62180/#review184922
-----------------------------------------------------------
This review is confusing. It requires the fix for GEODE-3557 which currently has its own PR (see https://github.com/apache/geode/pull/763).
So why did you submit this review? It looks like you just grabbed one line from that PR since it has also has the change.
I just wanted to make clear you should not checkin this code review because in your code base DM.getCache() does not exist.
- Darrel Schneider
On Sept. 7, 2017, 5:43 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62180/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 5:43 p.m.)
>
>
> Review request for geode, Barry Oglesby and Dan Smith.
>
>
> Bugs: GEODE-3557
> https://issues.apache.org/jira/browse/GEODE-3557
>
>
> Repository: geode
>
>
> Description
> -------
>
> use dm.getCache() instead
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/DestroyLuceneIndexMessage.java 9eada5b20
>
>
> Diff: https://reviews.apache.org/r/62180/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>