[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #301: DAFFODIL-2169 Add typesafty to our handling of infoset data values.

[GitBox <gi...@apache.org>]

bsloane1650 commented on a change in pull request #301: DAFFODIL-2169 Add typesafty to our handling of infoset data values.
URL: https://github.com/apache/incubator-daffodil/pull/301#discussion_r357462211
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ExpressionEvaluatingParsers.scala
 ##########
 @@ -163,9 +169,6 @@ class SetVariableParser(expr: CompiledExpression[AnyRef], decl: VariableRuntimeD
   def parse(start: PState): Unit = {
     log(LogLevel.Debug, "This is %s", toString) // important. Don't toString unless we have to log.
     val res = eval(start)
-    res match {
-      case ps: PState => return ;
-      case _ => /*fall through*/ }
 
 Review comment:
   Technically wouldn't ever cause an issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services