svn commit: r496863 - in /incubator/solr/trunk/client/ruby/solrb: lib/solr/request/select.rb test/unit/standard_request_test.rb

[eh...@apache.org]

Author: ehatcher
Date: Tue Jan 16 13:28:44 2007
New Revision: 496863

URL: http://svn.apache.org/viewvc?view=rev&rev=496863
Log:
Exempt nil parameters from the Solr request

Modified:
    incubator/solr/trunk/client/ruby/solrb/lib/solr/request/select.rb
    incubator/solr/trunk/client/ruby/solrb/test/unit/standard_request_test.rb

Modified: incubator/solr/trunk/client/ruby/solrb/lib/solr/request/select.rb
URL: http://svn.apache.org/viewvc/incubator/solr/trunk/client/ruby/solrb/lib/solr/request/select.rb?view=diff&rev=496863&r1=496862&r2=496863
==============================================================================
--- incubator/solr/trunk/client/ruby/solrb/lib/solr/request/select.rb (original)
+++ incubator/solr/trunk/client/ruby/solrb/lib/solr/request/select.rb Tue Jan 16 13:28:44 2007
@@ -40,9 +40,9 @@
         http_params = []
         raw_params.each do |key,value|
           if value.respond_to? :each
-            value.each { |v| http_params << "#{key}=#{ERB::Util::url_encode(v)}" }
+            value.each { |v| http_params << "#{key}=#{ERB::Util::url_encode(v)}" unless v.nil?}
           else
-            http_params << "#{key}=#{ERB::Util::url_encode(value)}"
+            http_params << "#{key}=#{ERB::Util::url_encode(value)}" unless value.nil?
           end
         end
 

Modified: incubator/solr/trunk/client/ruby/solrb/test/unit/standard_request_test.rb
URL: http://svn.apache.org/viewvc/incubator/solr/trunk/client/ruby/solrb/test/unit/standard_request_test.rb?view=diff&rev=496863&r1=496862&r2=496863
==============================================================================
--- incubator/solr/trunk/client/ruby/solrb/test/unit/standard_request_test.rb (original)
+++ incubator/solr/trunk/client/ruby/solrb/test/unit/standard_request_test.rb Tue Jan 16 13:28:44 2007
@@ -41,8 +41,15 @@
     assert_equal ['fq1','fq2'], request.to_hash[:fq]
     assert_equal "id,title,score", request.to_hash[:fl]
   end
+    
+  def test_empty_params
+    request = Solr::Request::Standard.new(:query => 'query', :debug_query => false)
+    assert_nil request.to_hash[:rows]
+    assert_no_match /rows/, request.to_s
+    assert_match /debugQuery/, request.to_s
+  end
   
-  def test_facet_params
+  def test_facet_params_all
     request = Solr::Request::Standard.new(:query => 'query',
        :facets => {
          :fields => [:genre,