You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/03/04 17:00:50 UTC
Review Request 70115: Updated comment about operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70115/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
A comment about operation feedback mentioned the master sending `OPERATION_DROPPED` updates for certain operations. However, such updates are only sent by agents; the master will send `OPERATION_ERROR` updates instead.
Diffs
-----
src/master/master.cpp 665c1c7979a5ae4ecec0d5a68e59c5419049a4d5
Diff: https://reviews.apache.org/r/70115/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70115: Updated comment about operations.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70115/#review213539
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On March 4, 2019, 9 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70115/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 9 a.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A comment about operation feedback mentioned the master sending `OPERATION_DROPPED` updates for certain operations. However, such updates are only sent by agents; the master will send `OPERATION_ERROR` updates instead.
>
>
> Diffs
> -----
>
> src/master/master.cpp 665c1c7979a5ae4ecec0d5a68e59c5419049a4d5
>
>
> Diff: https://reviews.apache.org/r/70115/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70115: Updated comment about operations.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70115/#review213403
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On March 4, 2019, 5 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70115/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 5 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A comment about operation feedback mentioned the master sending `OPERATION_DROPPED` updates for certain operations. However, such updates are only sent by agents; the master will send `OPERATION_ERROR` updates instead.
>
>
> Diffs
> -----
>
> src/master/master.cpp 665c1c7979a5ae4ecec0d5a68e59c5419049a4d5
>
>
> Diff: https://reviews.apache.org/r/70115/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70115: Updated comment about operations.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70115/#review213528
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On March 4, 2019, 9 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70115/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 9 a.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A comment about operation feedback mentioned the master sending `OPERATION_DROPPED` updates for certain operations. However, such updates are only sent by agents; the master will send `OPERATION_ERROR` updates instead.
>
>
> Diffs
> -----
>
> src/master/master.cpp 665c1c7979a5ae4ecec0d5a68e59c5419049a4d5
>
>
> Diff: https://reviews.apache.org/r/70115/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>