You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/03 11:16:03 UTC

[GitHub] [airflow] ashb commented on a change in pull request #17391: More touches on `dag_maker` fixture to create DagModel automatically

ashb commented on a change in pull request #17391:
URL: https://github.com/apache/airflow/pull/17391#discussion_r681664002



##########
File path: tests/conftest.py
##########
@@ -436,25 +436,27 @@ def dag_maker(request):
     DEFAULT_DATE = timezone.datetime(2016, 1, 1)
 
     class DagFactory:
-        def __enter__(self):
+        @provide_session
+        def __enter__(self, session=None):
             self.dag.__enter__()
+            self.session = session

Review comment:
       If we're going to store a session, we should do it in `__call__`, not `__enter__`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org