You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by kw...@apache.org on 2015/04/04 14:09:20 UTC
svn commit: r1671265 - in
/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server:
model/port/AmqpPortImpl.java protocol/MultiVersionProtocolEngine.java
Author: kwall
Date: Sat Apr 4 12:09:20 2015
New Revision: 1671265
URL: http://svn.apache.org/r1671265
Log:
QPID-6429: [Java Broker] Add more logging to investigate the failure to close ports in general (sporadic test failure)
Modified:
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPortImpl.java
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/protocol/MultiVersionProtocolEngine.java
Modified: qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPortImpl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPortImpl.java?rev=1671265&r1=1671264&r2=1671265&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPortImpl.java (original)
+++ qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPortImpl.java Sat Apr 4 12:09:20 2015
@@ -43,6 +43,8 @@ import javax.net.ssl.X509TrustManager;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.SettableFuture;
import org.codehaus.jackson.map.ObjectMapper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import org.apache.qpid.server.configuration.BrokerProperties;
import org.apache.qpid.server.configuration.IllegalConfigurationException;
@@ -75,6 +77,8 @@ import org.apache.qpid.transport.network
public class AmqpPortImpl extends AbstractClientAuthCapablePortWithAuthProvider<AmqpPortImpl> implements AmqpPort<AmqpPortImpl>
{
+ private static final Logger LOGGER = LoggerFactory.getLogger(AmqpPortImpl.class);
+
public static final String DEFAULT_BINDING_ADDRESS = "*";
@@ -260,10 +264,16 @@ public class AmqpPortImpl extends Abstra
@Override
protected ListenableFuture<Void> beforeClose()
{
+ LOGGER.debug("beforeClose ");
+
_closing.set(true);
+ //
+
if (_connectionCount.get() == 0)
{
+ LOGGER.debug("beforeClose - no connections remain");
+
_noConnectionsRemain.set(null);
}
@@ -509,8 +519,9 @@ public class AmqpPortImpl extends Abstra
@Override
public int decrementConnectionCount()
{
-
int openConnections = _connectionCount.decrementAndGet();
+ LOGGER.debug("decrementConnectionCount {}", openConnections);
+
int maxOpenConnections = getMaxOpenConnections();
if(maxOpenConnections > 0
@@ -521,6 +532,8 @@ public class AmqpPortImpl extends Abstra
if (_closing.get() && _connectionCount.get() == 0)
{
+ LOGGER.debug("decrementConnectionCount - No connections remain");
+
_noConnectionsRemain.set(null);
}
Modified: qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/protocol/MultiVersionProtocolEngine.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/protocol/MultiVersionProtocolEngine.java?rev=1671265&r1=1671264&r2=1671265&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/protocol/MultiVersionProtocolEngine.java (original)
+++ qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/protocol/MultiVersionProtocolEngine.java Sat Apr 4 12:09:20 2015
@@ -122,6 +122,8 @@ public class MultiVersionProtocolEngine
public void closed()
{
+ _logger.debug("Closed");
+
try
{
_delegate.closed();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org