[GitHub] [qpid-dispatch] franz1981 commented on issue #510: DISPATCH-1343 Faster qd_buffer and qd_message allocations

[GitBox <gi...@apache.org>]

franz1981 commented on issue #510: DISPATCH-1343 Faster qd_buffer and qd_message allocations
URL: https://github.com/apache/qpid-dispatch/pull/510#issuecomment-495730650
 
 
   I've spent some time looking at the perf of this changes and it seems that the new way to allocate qd_buffer without issuing a full memory barrier is slower then the original one, because I was expecting the latter to use C11 variant of sys_atomic_init in atomic.h, while instead it was using the GNU version.
   The point is that some of atomic operation doesn't seem correct to me from a memory model point of view and that's why the original version (that was just doing a plain store!) was faster then this one, that was issuing a compiler barrier for correctness.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org