You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markobean <gi...@git.apache.org> on 2018/08/21 16:13:47 UTC
[GitHub] nifi pull request #2957: NIFI-5543: fix connection path is not visualizing a...
GitHub user markobean opened a pull request:
https://github.com/apache/nifi/pull/2957
NIFI-5543: fix connection path is not visualizing as selected when hi…
…dden linepoint element is clicked
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
Fix was verified by installing and manual UI manipulation. Now, when a bend point of a currently unselected connection is clicked, that connection becomes selected/highlighted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markobean/nifi NIFI-5543
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2957.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2957
----
commit 4b719c6d9019e1aeabfd5205540ede5653d6236c
Author: Mark Bean <ma...@...>
Date: 2018-08-21T15:37:25Z
NIFI-5543: fix connection path is not visualizing as selected when hidden linepoint element is clicked
----
---
[GitHub] nifi issue #2957: NIFI-5543: fix connection path is not visualizing as selec...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2957
@markobean I've replicated the behavior and believe there is a bug here. However, I don't think the proposed solution is the proper way to address it. The points in question are `visibility: hidden` to ensure they remain clickable. I believe the issue is the order the drag behavior is added to the points. Can you please try moving the drag behavior for the `midpoints` and the `endpoints` to below where the `mousedown` listeners are registered and see if that addresses the issue.
---
[GitHub] nifi issue #2957: NIFI-5543: fix connection path is not visualizing as selec...
Posted by markobean <gi...@git.apache.org>.
Github user markobean commented on the issue:
https://github.com/apache/nifi/pull/2957
@scottyaslan This behavior has been confirmed on Firefox 56.0 and Chrome 50.0. Granted these are not Current or (Current -1). What browser/version are you using?
---
[GitHub] nifi issue #2957: NIFI-5543: fix connection path is not visualizing as selec...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2957
Chrome Version 68.0.3440.106 (Official Build) (64-bit)
---
[GitHub] nifi pull request #2957: NIFI-5543: fix connection path is not visualizing a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2957
---
[GitHub] nifi issue #2957: NIFI-5543: fix connection path is not visualizing as selec...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2957
Thanks @markobean! This has been merged to master.
---
[GitHub] nifi issue #2957: NIFI-5543: fix connection path is not visualizing as selec...
Posted by markobean <gi...@git.apache.org>.
Github user markobean commented on the issue:
https://github.com/apache/nifi/pull/2957
@scottyaslan The connections do not need to be overlapping to experience the bad behavior. As the JIRA ticket says, "Select a connection. Then, select another connection on its bend point." These connections do not need to be overlapping. In both cases, the second connection can be manipulated while the first connection still displays as highlighted. That is the behavior prior to this fix, that is.
---
[GitHub] nifi issue #2957: NIFI-5543: fix connection path is not visualizing as selec...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2957
@markobean sorry, but I still cannot reproduce the issue. I have a GenerateFlowFile processor with 2 connections to an UpdateAttribute processor. Each of the connection has bend point. I click on the first connection and I see that connection is highlighted. I click on the second connection by one of its bend points and the second connection is now highlighted. Please advise...
---
[GitHub] nifi issue #2957: NIFI-5543: fix connection path is not visualizing as selec...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2957
Reviewing...
@markobean can you please provide steps to test this?
It sounds like you have 2 connections overlaid on top of each other and that the 'bottom' connection has a bend point. Is that correct? and that you are trying to select the bottom connection by its' bend point?
If that is what you are trying to do then there may already be a solution for this...if you right click on the connection you are trying to edit you should then be able to select 'Bring to front' from the context menu. Then when you click the bend point you will have the desired connection.
---