You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/01 14:00:46 UTC
[GitHub] [spark] grundprinzip opened a new pull request, #38863: [SPARK-41351][CONNECT] Column should support != operator
grundprinzip opened a new pull request, #38863:
URL: https://github.com/apache/spark/pull/38863
### What changes were proposed in this pull request?
This patch fixes a bug that the `Column` does not support the != operator.
### Why are the changes needed?
Compat
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38863: [SPARK-41351][CONNECT] Column should support != operator
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38863:
URL: https://github.com/apache/spark/pull/38863#discussion_r1037733426
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -870,6 +870,11 @@ def test_agg_with_avg(self):
self.assertEqual(4.0, res[0][1])
self.assertEqual(5.0, res[1][1])
+ def test_column_operator(self):
Review Comment:
or create one `test_connect_columns.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38863: [SPARK-41351][CONNECT] Column should support != operator
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38863:
URL: https://github.com/apache/spark/pull/38863#discussion_r1038017951
##########
python/pyspark/sql/tests/connect/test_connect_column.py:
##########
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+import unittest
+
+from pyspark.sql.tests.connect.test_connect_basic import SparkConnectSQLTestCase
+from pyspark.testing.sqlutils import have_pandas
+
+if have_pandas:
+ pass
+
Review Comment:
```suggestion
```
##########
python/pyspark/sql/tests/connect/test_connect_column.py:
##########
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+import unittest
+
+from pyspark.sql.tests.connect.test_connect_basic import SparkConnectSQLTestCase
+from pyspark.testing.sqlutils import have_pandas
+
+if have_pandas:
+ pass
+
Review Comment:
Seems a mistake :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38863: [SPARK-41351][CONNECT] Column should support != operator
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38863: [SPARK-41351][CONNECT] Column should support != operator
URL: https://github.com/apache/spark/pull/38863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38863: [SPARK-41351][CONNECT] Column should support != operator
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38863:
URL: https://github.com/apache/spark/pull/38863#discussion_r1037476750
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -870,6 +870,11 @@ def test_agg_with_avg(self):
self.assertEqual(4.0, res[0][1])
self.assertEqual(5.0, res[1][1])
+ def test_column_operator(self):
Review Comment:
nit: maybe we should move all such tests to `test_connect_functions.py`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38863: [SPARK-41351][CONNECT] Column should support != operator
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38863:
URL: https://github.com/apache/spark/pull/38863#discussion_r1037476750
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -870,6 +870,11 @@ def test_agg_with_avg(self):
self.assertEqual(4.0, res[0][1])
self.assertEqual(5.0, res[1][1])
+ def test_column_operator(self):
Review Comment:
nit: maybe we should move such tests to `test_connect_functions.py`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38863: [SPARK-41351][CONNECT] Column should support != operator
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38863:
URL: https://github.com/apache/spark/pull/38863#issuecomment-1334720530
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38863: [SPARK-41351][CONNECT] Column should support != operator
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38863:
URL: https://github.com/apache/spark/pull/38863#issuecomment-1336587827
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org