You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/02/02 01:53:56 UTC
[GitHub] incubator-zeppelin pull request: Propagate maven -DskipTests optio...
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/682
Propagate maven -DskipTests option to WebApp
### What is this PR for?
This PR has for goal to help people build Zeppelin when phantomJS is not working properly on their machine:
* [Some Problems Here](https://mail-archives.apache.org/mod_mbox/incubator-zeppelin-users/201509.mbox/%3CCAKhwvQtTCDeXaQOhpu+wvxPj1io4ra+dG=mEQE7eVR5xboB8eA@mail.gmail.com%3E)
* [Here Too](https://mail-archives.apache.org/mod_mbox/incubator-zeppelin-users/201511.mbox/%3CCABePtM3iMeWayAqOzeDahcL-Bz8A3uXUqSuMU41dehWXMd_vmA@mail.gmail.com%3E)
* And more
Currently, you have to edit some code in order to bypass the test launched by grunt, and it doesn't seem right for `-DskipTests` to no skip the WebApp tests.
In order to apply that rule, we need to bump the version of `frontend-maven-plugin` to 0.0.25. Sadly they do not have a changelog, so we need to make sure everything is alright.
### What type of PR is it?
Improvement
### Todos
* [ ] - Change version in license
### Is there a relevant Jira issue?
Related: https://issues.apache.org/jira/browse/ZEPPELIN-403
https://issues.apache.org/jira/browse/ZEPPELIN-644
### How should this be tested?
* You should clear your bower cache, since we changed a dependency version.
* Run `mvn package` inside zeppelin-web folder and assess that the test were ran
```
Running "karma:unit" (karma) task
[INFO] INFO [karma]: Karma v0.12.37 server started at http://localhost:9002/
[INFO] INFO [launcher]: Starting browser PhantomJS
[INFO] INFO [PhantomJS 1.9.8 (Mac OS X 0.0.0)]: Connected on socket OHBv4N47NmnKdZx9YUm7 with id 61917714
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 37 of 82 SUCCESS (0 secs / 0.249 secs)
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 82 of 82 SUCCESS (0.578 secs / 0.562 secs)
```
* Run `mvn package -DskipTests` and assess that PhantomJS didnt run
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/skipTestsOnWebApp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/682.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #682
----
commit 3d0c71076d333c265c7076c85fc7ae6aa75ec946
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-02-02T00:31:47Z
Change frontend-maven-plugin conf & version to propagate skipTests to webApp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Propagate maven -DskipTests optio...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/682#issuecomment-178649202
Merging if there's no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Propagate maven -DskipTests optio...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/682#issuecomment-178382060
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Propagate maven -DskipTests optio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/682
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Propagate maven -DskipTests optio...
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/682#issuecomment-179286219
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Propagate maven -DskipTests optio...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/682#issuecomment-179099186
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Propagate maven -DskipTests optio...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/682#issuecomment-178472905
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---