[GitHub] rabbah commented on a change in pull request #2832: Do not cache invalidate when adding a DB attachment

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #2832: Do not cache invalidate when adding a DB attachment
URL: https://github.com/apache/incubator-openwhisk/pull/2832#discussion_r154919634
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/database/DocumentFactory.scala
 ##########
 @@ -166,24 +166,29 @@ trait DocumentFactory[W] extends MultipleReadersSingleWriterCache[W, DocInfo] {
 
   def attach[Wsuper >: W](
     db: ArtifactStore[Wsuper],
+    entity: W,
     doc: DocInfo,
     attachmentName: String,
     contentType: ContentType,
     bytes: InputStream)(implicit transid: TransactionId, notifier: Option[CacheChangeNotification]): Future[DocInfo] = {
 
     Try {
       require(db != null, "db undefined")
+      require(entity != null, "entity undefined")
       require(doc != null, "doc undefined")
 
 Review comment:
   Yeah we can have a separate cleanup that removes these which date back to the gson serdes. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services