You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2022/01/05 22:09:45 UTC
[GitHub] [fluo-muchos] keith-turner opened a new pull request #426: avoids starting tracer for Accumulo 2.1.0
keith-turner opened a new pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426
Trying to start the tracer for Accumulo 2.1.0-SNAPSHOT was causing problems. Changed code to avoid doing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1007846527
> * ansible/wipe-systemd.yml: the accumulo-tracer service won't exist so it can't be stopped
It can be made conditional for sure though, but JFYI it is benign as Ansible will not error when the service does not exist.
> * ansible/roles/accumulo/files/accumulo-cluster-systemd: this might need to be turned into a jinja template so the tracer sections can be included conditionally
This should be ideally addressed in this PR itself. Currently the `accumulo-cluster-systemd` script errors out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781601391
##########
File path: ansible/roles/accumulo/templates/accumulo-cluster-systemd
##########
@@ -287,26 +292,35 @@ function stop_all() {
done
wait
+{% if accumulo_version is version('2.1.0','<') %}
for tracer in $(grep -E -v '(^#|^\s*$)' "${conf}/tracers"); do
stop_service "$tracer" tracer &
done
wait
+{% endif %}
# stop tserver still running
stop_tservers
echo "Cleaning all server entries in ZooKeeper"
+{% if accumulo_version is version('2.1.0','<') %}
${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -master -tservers -tracers
+{% else %}
+ ${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -manager -tservers
+{% endif %}
}
function stop_here() {
# Determine hostname without errors to user
hosts_to_check=("$(hostname -a 2> /dev/null | head -1)" "$(hostname -f)")
for host in "${hosts_to_check[@]}"; do
- for svc in tserver gc master monitor tracer; do
+ for svc in tserver gc master monitor; do
stop_service "$host" "$svc"
done
+{% if accumulo_version is version('2.1.0','<') %}
+ stop_service "$host" "tracer"
+{% endif %}
Review comment:
@brianloss I applied this change and when I test if locally it failed... looked into it and I had to add and `else''`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781601391
##########
File path: ansible/roles/accumulo/templates/accumulo-cluster-systemd
##########
@@ -287,26 +292,35 @@ function stop_all() {
done
wait
+{% if accumulo_version is version('2.1.0','<') %}
for tracer in $(grep -E -v '(^#|^\s*$)' "${conf}/tracers"); do
stop_service "$tracer" tracer &
done
wait
+{% endif %}
# stop tserver still running
stop_tservers
echo "Cleaning all server entries in ZooKeeper"
+{% if accumulo_version is version('2.1.0','<') %}
${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -master -tservers -tracers
+{% else %}
+ ${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -manager -tservers
+{% endif %}
}
function stop_here() {
# Determine hostname without errors to user
hosts_to_check=("$(hostname -a 2> /dev/null | head -1)" "$(hostname -f)")
for host in "${hosts_to_check[@]}"; do
- for svc in tserver gc master monitor tracer; do
+ for svc in tserver gc master monitor; do
stop_service "$host" "$svc"
done
+{% if accumulo_version is version('2.1.0','<') %}
+ stop_service "$host" "tracer"
+{% endif %}
Review comment:
@brianloss I applied this change and when I test if locally it failed... looked into it and I had to add and `else ''`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1010302064
> Strange... the Python version is still 3.9.9, so that has not changed. Anyways looks like bumping the version of ansible-lint is a simple fix.
Not completely sure, but I think the new version of ansible lint may have the following which fixes the issue with breaking change in one of its dependencies.
https://github.com/ansible-community/ansible-lint/pull/1797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r779911110
##########
File path: ansible/accumulo.yml
##########
@@ -53,16 +53,18 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.0 master, monitor, & gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
- hosts: accumulomaster
tasks:
- name: "install and start all the accumulo services using systemd"
Review comment:
I changed the systemd code later in the file but didn't test it (I did run muchos setup again and that was ok, but did not try enabling systemd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r782603536
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,34 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ register: start_tracer_result
+ changed_when: "'Starting' in start_tracer_result.stdout"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
- hosts: accumulomaster
tasks:
- name: "install and start all the accumulo services using systemd"
block:
- import_tasks: roles/accumulo/tasks/start-master.yml
- import_tasks: roles/accumulo/tasks/start-gc.yml
- import_tasks: roles/accumulo/tasks/start-monitor.yml
- - import_tasks: roles/accumulo/tasks/start-tracer.yml
when: use_systemd
become: yes
+ - name: "install and start all the accumulo tracer service using systemd"
+ block:
+ - import_tasks: roles/accumulo/tasks/start-tracer.yml
+ when: use_systemd and accumulo_version is version('2.1.0','<')
Review comment:
@keith-turner - sorry, I just spotted this, should it not be:
```suggestion
when: accumulo_version is version('2.0.0','>=') and use_systemd and accumulo_version is version('2.1.0','<')
```
We really don't block someone from setting use_systemd to `True` when using Accumulo 1.x so I guess it is safer to filter this way.
to be consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1006117988
I have only tested this change w/ 2.1.0-SNAPSHOT and it fixed the problem I was seeing. I have not tried running Muchos w/ 2.0.0 though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r779278605
##########
File path: ansible/accumulo.yml
##########
@@ -53,16 +53,18 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.0 master, monitor, & gc"
Review comment:
```suggestion
- name: "start accumulo 2.x master, monitor, and gc"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r780602067
##########
File path: ansible/accumulo.yml
##########
@@ -53,16 +53,18 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.0 master, monitor, & gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
- hosts: accumulomaster
tasks:
- name: "install and start all the accumulo services using systemd"
Review comment:
@keith-turner - I did test your latest changes with accumulo-2.1.0-SNAPSHOT built off accumulo main, with systemd enabled. While setup did complete without any errors, the observations from @brianloss need to be addressed sometime - especially the accumulo-cluster-systemd script errors out.
BTW, unrelated to this change, the accumulo-cluster-systemd also errors out due to lack of change to `manager` from the older term. That is an unrelated issue and can be cleaned up separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r780602067
##########
File path: ansible/accumulo.yml
##########
@@ -53,16 +53,18 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.0 master, monitor, & gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
- hosts: accumulomaster
tasks:
- name: "install and start all the accumulo services using systemd"
Review comment:
@keith-turner - I did test your latest changes with accumulo-2.1.0-SNAPSHOT built off accumulo main, with systemd enabled. While setup did complete without any errors, the observations from @brianloss need to be addressed sometime - especially the accumulo-cluster-systemd script errors out.
BTW, unrelated to this change, the accumulo-cluster-systemd also errors out due to lack of change to `manager` from the older term. That is an unrelated issue and can be cleaned up separately.
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,32 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
Review comment:
yes, what this would do is to make Ansible report a green "ok" status for that play / task, when tracer is already running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] brianloss commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
brianloss commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781484419
##########
File path: ansible/roles/accumulo/templates/accumulo-cluster-systemd
##########
@@ -75,6 +75,7 @@ function verify_config {
fi
fi
+{% if accumulo_version is version('2.1.0','<') %}
Review comment:
I'm not a jinja expert, and this would totally be a nit, but you can specify a dash after the begin and or before the close. That will remove whitespace. A pattern I've seen before is something like:
```
{%- some jinja conditional %}
stuff
{% end -%}
```
The only difference this would make is how clean the file looks after it's been run through the template engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] brianloss commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
brianloss commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781538639
##########
File path: ansible/roles/accumulo/templates/accumulo-cluster-systemd
##########
@@ -287,26 +292,35 @@ function stop_all() {
done
wait
+{% if accumulo_version is version('2.1.0','<') %}
for tracer in $(grep -E -v '(^#|^\s*$)' "${conf}/tracers"); do
stop_service "$tracer" tracer &
done
wait
+{% endif %}
# stop tserver still running
stop_tservers
echo "Cleaning all server entries in ZooKeeper"
+{% if accumulo_version is version('2.1.0','<') %}
${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -master -tservers -tracers
+{% else %}
+ ${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -manager -tservers
+{% endif %}
Review comment:
Oops, yeah I glossed over the master/manager change too. Makes more sense the way you have it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft edited a comment on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft edited a comment on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1007846527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r780606520
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,32 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
Review comment:
yes, what this would do is to make Ansible report a green "ok" status for that play / task, when tracer is already running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781480546
##########
File path: ansible/accumulo.yml
##########
@@ -53,16 +53,18 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.0 master, monitor, & gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
- hosts: accumulomaster
tasks:
- name: "install and start all the accumulo services using systemd"
Review comment:
> BTW, unrelated to this change, the accumulo-cluster-systemd also errors out due to lack of change to manager from the older term. That is an unrelated issue and can be cleaned up separately.
I made one small change related to this in daeab54 because I was touching that code. Looking at the file its pervasive , so would be nicer to do that in its own PR. I wonder if we can avoid a bunch of if stmts in the template and just have template variable that resolves to manager or master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781532941
##########
File path: ansible/roles/accumulo/templates/accumulo-cluster-systemd
##########
@@ -287,26 +292,35 @@ function stop_all() {
done
wait
+{% if accumulo_version is version('2.1.0','<') %}
for tracer in $(grep -E -v '(^#|^\s*$)' "${conf}/tracers"); do
stop_service "$tracer" tracer &
done
wait
+{% endif %}
# stop tserver still running
stop_tservers
echo "Cleaning all server entries in ZooKeeper"
+{% if accumulo_version is version('2.1.0','<') %}
${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -master -tservers -tracers
+{% else %}
+ ${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -manager -tservers
+{% endif %}
Review comment:
I had also thrown in that manager change, but that does not have to be done in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft edited a comment on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft edited a comment on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1007846527
> * ansible/wipe-systemd.yml: the accumulo-tracer service won't exist so it can't be stopped
It can be made conditional for sure though, but JFYI it is benign as Ansible will not error when the service does not exist.
> * ansible/roles/accumulo/files/accumulo-cluster-systemd: this might need to be turned into a jinja template so the tracer sections can be included conditionally
This should be ideally addressed in this PR itself. Currently the `accumulo-cluster-systemd` script errors out when run with 2.1.0-SNAPSHOT and systemd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft edited a comment on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft edited a comment on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1007846527
> * ansible/wipe-systemd.yml: the accumulo-tracer service won't exist so it can't be stopped
It can be made conditional for sure though, but JFYI it is benign as Ansible will not error when the service does not exist.
> * ansible/roles/accumulo/files/accumulo-cluster-systemd: this might need to be turned into a jinja template so the tracer sections can be included conditionally
This should be ideally addressed in this PR itself. Currently the `accumulo-cluster-systemd` script errors out when run with 2.1.0-SNAPSHOT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781603887
##########
File path: ansible/roles/accumulo/templates/accumulo-cluster-systemd
##########
@@ -75,6 +75,7 @@ function verify_config {
fi
fi
+{% if accumulo_version is version('2.1.0','<') %}
Review comment:
I tried playing around with this feature locally and seeing how it rendered. I didn't use it, but as a result I moved a few empty lines there were outside the template to inside of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1010337734
> > Strange... the Python version is still 3.9.9, so that has not changed. Anyways looks like bumping the version of ansible-lint is a simple fix.
>
> Not completely sure, but I think the new version of ansible lint may have the following which fixes the issue with breaking change in one of its dependencies.
>
> [ansible-community/ansible-lint#1797](https://github.com/ansible-community/ansible-lint/pull/1797)
I'll double-check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r782603536
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,34 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ register: start_tracer_result
+ changed_when: "'Starting' in start_tracer_result.stdout"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
- hosts: accumulomaster
tasks:
- name: "install and start all the accumulo services using systemd"
block:
- import_tasks: roles/accumulo/tasks/start-master.yml
- import_tasks: roles/accumulo/tasks/start-gc.yml
- import_tasks: roles/accumulo/tasks/start-monitor.yml
- - import_tasks: roles/accumulo/tasks/start-tracer.yml
when: use_systemd
become: yes
+ - name: "install and start all the accumulo tracer service using systemd"
+ block:
+ - import_tasks: roles/accumulo/tasks/start-tracer.yml
+ when: use_systemd and accumulo_version is version('2.1.0','<')
Review comment:
@keith-turner - sorry, I just spotted this, should it not be:
```suggestion
when: accumulo_version is version('2.0.0','>=') and use_systemd and accumulo_version is version('2.1.0','<')
```
We really don't block someone from setting use_systemd to `True` when using Accumulo 1.x so I guess it is safer to filter this way. The suggested way would also be consistent with other changes in this PR where equivalent conditions are present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] brianloss commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
brianloss commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781488775
##########
File path: ansible/roles/accumulo/templates/accumulo-cluster-systemd
##########
@@ -287,26 +292,35 @@ function stop_all() {
done
wait
+{% if accumulo_version is version('2.1.0','<') %}
for tracer in $(grep -E -v '(^#|^\s*$)' "${conf}/tracers"); do
stop_service "$tracer" tracer &
done
wait
+{% endif %}
# stop tserver still running
stop_tservers
echo "Cleaning all server entries in ZooKeeper"
+{% if accumulo_version is version('2.1.0','<') %}
${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -master -tservers -tracers
+{% else %}
+ ${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -manager -tservers
+{% endif %}
}
function stop_here() {
# Determine hostname without errors to user
hosts_to_check=("$(hostname -a 2> /dev/null | head -1)" "$(hostname -f)")
for host in "${hosts_to_check[@]}"; do
- for svc in tserver gc master monitor tracer; do
+ for svc in tserver gc master monitor; do
stop_service "$host" "$svc"
done
+{% if accumulo_version is version('2.1.0','<') %}
+ stop_service "$host" "tracer"
+{% endif %}
Review comment:
This could be kept together too. It's probably just preference in the end over what looks better to you.
```suggestion
for svc in tserver gc master monitor{{ ' tracer' if accumulo_version is version('2.1.0','<') }}; do
stop_service "$host" "$svc"
done
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1009184517
> - ansible/wipe-systemd.yml: the accumulo-tracer service won't exist so it can't be stopped
Based on what @arvindshmicrosoft said, I think it would be best to do nothing for this case. Keeps the ansible code simpler.
> - ansible/roles/accumulo/files/accumulo-cluster-systemd: this might need to be turned into a jinja template so the tracer sections can be included conditionally
Looking into doing this.
> - ansible/roles/accumulo/tasks/main.yml: don't copy the tracers file for >= 2.1.0
> - ansible/roles/accumulo/templates/accumulo-env.sh: remove tracer from the accumulo 2.1.0 case
Did these in 7dcc217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1010296710
> The build is failing. May be running into this issue [ansible-community/ansible-lint#1795](https://github.com/ansible-community/ansible-lint/issues/1795)
Strange... the Python version is still 3.9.9, so that has not changed. Anyways looks like bumping the version of ansible-lint is a simple fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781601391
##########
File path: ansible/roles/accumulo/templates/accumulo-cluster-systemd
##########
@@ -287,26 +292,35 @@ function stop_all() {
done
wait
+{% if accumulo_version is version('2.1.0','<') %}
for tracer in $(grep -E -v '(^#|^\s*$)' "${conf}/tracers"); do
stop_service "$tracer" tracer &
done
wait
+{% endif %}
# stop tserver still running
stop_tservers
echo "Cleaning all server entries in ZooKeeper"
+{% if accumulo_version is version('2.1.0','<') %}
${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -master -tservers -tracers
+{% else %}
+ ${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -manager -tservers
+{% endif %}
}
function stop_here() {
# Determine hostname without errors to user
hosts_to_check=("$(hostname -a 2> /dev/null | head -1)" "$(hostname -f)")
for host in "${hosts_to_check[@]}"; do
- for svc in tserver gc master monitor tracer; do
+ for svc in tserver gc master monitor; do
stop_service "$host" "$svc"
done
+{% if accumulo_version is version('2.1.0','<') %}
+ stop_service "$host" "tracer"
+{% endif %}
Review comment:
@brianloss I applied this change and when I test if locally it failed... looked into it and I had to add an `else ''`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner merged pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner merged pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] brianloss commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
brianloss commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r779510698
##########
File path: ansible/accumulo.yml
##########
@@ -53,16 +53,18 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.0 master, monitor, & gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
- hosts: accumulomaster
tasks:
- name: "install and start all the accumulo services using systemd"
Review comment:
Yes, that would be needed. If you expand this file, it's on line 73/75 below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r780065250
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,32 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
Review comment:
To be equivalent to what's in the other task, I think you also need:
```suggestion
when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
register: start_tracer_result
changed_when: "'Starting' in start_tracer_result.stdout"
```
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,32 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
Review comment:
To be equivalent to what's in the other task, I think you also need:
```suggestion
register: start_tracer_result
changed_when: "'Starting' in start_tracer_result.stdout"
when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1006141365
> For completeness, can you share the details about the original error you encountered?
@arvindshmicrosoft this is the error I saw.
```
TASK [start accumulo 2.0 master, monitor, gc & tracer] **********************************************************************************************************************************************************
Wednesday 05 January 2022 17:53:37 +0000 (0:00:00.766) 0:03:01.386 *****
changed: [ktwal2-0] => (item=master)
changed: [ktwal2-0] => (item=monitor)
changed: [ktwal2-0] => (item=gc)
failed: [ktwal2-0] (item=tracer) => {"ansible_loop_var": "item", "changed": false, "cmd": ["nohup", "/home/centos/install/accumulo-2.1.0-SNAPSHOT/bin/accumulo-service", "tracer", "start"], "delta": "0:00:00.071548", "end": "2022-01-05 17:53:43.238652", "item": "tracer", "msg": "non-zero return code", "rc": 1, "start": "2022-01-05 17:53:43.167104", "stderr": "nohup: ignoring input\nUsage: accumulo-service <service> <command>\n\nServices:\n gc Accumulo garbage collector\n monitor Accumulo monitor\n manager Accumulo manager\n master Accumulo master (Deprecated)\n tserver Accumulo tserver\n compaction-coordinator Accumulo compaction coordinator (experimental)\n compactor Accumulo compactor (experimental)\n\nCommands:\n start Starts service\n stop Stops service\n kill Kills service", "stderr_lines": ["nohup: ignoring input", "Usage: accumulo-service <service> <com
mand>", "", "Services:", " gc
Accumulo garbage collector", " monitor Accumulo monitor", " manager Accumulo manager", " master Accumulo master (Deprecated)", " tserver Accumulo tserver", " compaction-coordinator Accumulo compaction coordinator (experimental)", " compactor Accumulo compactor (experimental)", "", "Commands:", " start Starts service", " stop Stops service", " kill Kills service"], "stdout": "Invalid arguments: 'tracer' is an invalid <service>", "stdout_lines": ["Invalid arguments: 'tracer' is an invalid <service>"]}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r780065250
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,32 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
Review comment:
To be equivalent to what's in the other task, I think you also need:
```suggestion
register: start_tracer_result
changed_when: "'Starting' in start_tracer_result.stdout"
when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] brianloss commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
brianloss commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781486224
##########
File path: ansible/roles/accumulo/templates/accumulo-cluster-systemd
##########
@@ -287,26 +292,35 @@ function stop_all() {
done
wait
+{% if accumulo_version is version('2.1.0','<') %}
for tracer in $(grep -E -v '(^#|^\s*$)' "${conf}/tracers"); do
stop_service "$tracer" tracer &
done
wait
+{% endif %}
# stop tserver still running
stop_tservers
echo "Cleaning all server entries in ZooKeeper"
+{% if accumulo_version is version('2.1.0','<') %}
${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -master -tservers -tracers
+{% else %}
+ ${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -manager -tservers
+{% endif %}
Review comment:
Wondering if this would be better as a single line or not?
```suggestion
${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -master -tservers{{ ' -tracers' if accumulo_version is version('2.1.0','<') }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1006127349
For completeness, can you share the details about the original error you encountered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1006143226
I think the problem was caused by the tracer service being removed in apache/accumulo#2259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r780065250
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,32 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
Review comment:
To be equivalent to what's in the other task, I think you also need:
```suggestion
when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
register: start_tracer_result
changed_when: "'Starting' in start_tracer_result.stdout"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1007846527
> * ansible/wipe-systemd.yml: the accumulo-tracer service won't exist so it can't be stopped
It can be made conditional for sure though, but JFYI it is benign as Ansible will not error when the service does not exist.
> * ansible/roles/accumulo/files/accumulo-cluster-systemd: this might need to be turned into a jinja template so the tracer sections can be included conditionally
This should be ideally addressed in this PR itself. Currently the `accumulo-cluster-systemd` script errors out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r779248113
##########
File path: ansible/accumulo.yml
##########
@@ -53,16 +53,18 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.0 master, monitor, & gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
- hosts: accumulomaster
tasks:
- name: "install and start all the accumulo services using systemd"
Review comment:
There will be similar set of `when` conditions needed for the systemd unit for tracer. It would be good to address that as well in this PR, or maybe log an Issue to track the future change needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781603887
##########
File path: ansible/roles/accumulo/templates/accumulo-cluster-systemd
##########
@@ -75,6 +75,7 @@ function verify_config {
fi
fi
+{% if accumulo_version is version('2.1.0','<') %}
Review comment:
I tried playing around with this feature locally and seeing how it rendered. I didn't use it, but as a result I moved a few empty lines that were outside the template sections to inside of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on pull request #426: avoids starting tracer for Accumulo 2.1.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#issuecomment-1010083093
The build is failing. May be running into this issue https://github.com/ansible-community/ansible-lint/issues/1795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org