You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/27 09:48:02 UTC
[GitHub] [incubator-apisix-docker] gxthrj opened a new pull request #68: [doc] change config.sh to gen-config-yaml.sh #67
gxthrj opened a new pull request #68:
URL: https://github.com/apache/incubator-apisix-docker/pull/68
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-docker] gxthrj commented on pull request #68: [doc] change config.sh to gen-config-yaml.sh #67
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #68:
URL: https://github.com/apache/incubator-apisix-docker/pull/68#issuecomment-664767159
> @gxthrj
>
> 
the comment has been changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-docker] membphis commented on pull request #68: [doc] change config.sh to gen-config-yaml.sh #67
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #68:
URL: https://github.com/apache/incubator-apisix-docker/pull/68#issuecomment-664327640
@gxthrj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-docker] gxthrj commented on a change in pull request #68: [doc] change config.sh to gen-config-yaml.sh #67
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #68:
URL: https://github.com/apache/incubator-apisix-docker/pull/68#discussion_r461307104
##########
File path: example/gen-config-yaml.sh
##########
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+export etcd_url='http://172.18.5.10:2379'
Review comment:
yes, in docker-compose.yaml special the ip for etcd server
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-docker] membphis merged pull request #68: [doc] change config.sh to gen-config-yaml.sh #67
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #68:
URL: https://github.com/apache/incubator-apisix-docker/pull/68
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-docker] membphis commented on a change in pull request #68: [doc] change config.sh to gen-config-yaml.sh #67
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #68:
URL: https://github.com/apache/incubator-apisix-docker/pull/68#discussion_r460798907
##########
File path: example/gen-config-yaml.sh
##########
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+export etcd_url='http://172.18.5.10:2379'
Review comment:
Shouldn't there be a fixed IP?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org