[GitHub] [zookeeper] phunt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255

[GitBox <gi...@apache.org>]

phunt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255
URL: https://github.com/apache/zookeeper/pull/832#discussion_r265270041
 
 

 ##########
 File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
 ##########
 @@ -212,7 +212,8 @@ ensemble:
   consists of a single line containing only the text of that machine's
   id. So *myid* of server 1 would contain the text
   "1" and nothing else. The id must be unique within the
-  ensemble and should have a value between 1 and 255.
+  ensemble and must have a value between 0 and 255.
 
 Review comment:
   Is there a reason why we are changing the official spec here? (as official as we get at least). Perhaps we should continue to enforce the "don't use zero" rule? Not sure I have a strong feeling either way but this has been on the books since ZOOKEEPER-260
   
   Reserving 0 may be a good idea for something in the future...?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services