You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by "javeme (via GitHub)" <gi...@apache.org> on 2023/02/06 16:38:32 UTC
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #2100: fix: some reference url and 3rd-party file license
javeme commented on code in PR #2100:
URL: https://github.com/apache/incubator-hugegraph/pull/2100#discussion_r1097629303
##########
NOTICE:
##########
@@ -5,3 +5,34 @@ This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
The initial codebase was donated to the ASF by HugeGraph Authors, copyright 2017-2021.
+
+
+// ------------------------------------------------------------------
+// NOTICE file corresponding to the section 4d of The Apache License,
+// Version 2.0, in this case for JanusGraph
+// ------------------------------------------------------------------
+
+JanusGraph
+Copyright (C) 2002, 2016, Oracle and/or its affiliates. All rights reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License") reproduced below or available at:
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+
+
+// ------------------------------------------------------------------
+// NOTICE file corresponding to the section 4d of The Apache License,
+// Version 2.0, in this case for Apache TinkerPop
+// ------------------------------------------------------------------
+
+Apache TinkerPop
Review Comment:
according to the order of https://github.com/apache/incubator-hugegraph/pull/2100/files#diff-f8a05717594bf148241760c18447442978fdc9db03a4aae93739529e0c124f8aR92, can we keep TinkerPop first and move to line 8?
##########
NOTICE:
##########
@@ -5,3 +5,34 @@ This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
The initial codebase was donated to the ASF by HugeGraph Authors, copyright 2017-2021.
+
+
+// ------------------------------------------------------------------
+// NOTICE file corresponding to the section 4d of The Apache License,
+// Version 2.0, in this case for JanusGraph
+// ------------------------------------------------------------------
+
+JanusGraph
+Copyright (C) 2002, 2016, Oracle and/or its affiliates. All rights reserved.
Review Comment:
is this comment addressed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org