[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #5563: [IOTDB-2938]Some improvements and bug fix for New Sync

[GitBox <gi...@apache.org>]

Cpaulyz commented on code in PR #5563:
URL: https://github.com/apache/iotdb/pull/5563#discussion_r851717016


##########
integration/src/test/java/org/apache/iotdb/db/integration/sync/IoTDBSyncSenderIT.java:
##########
@@ -276,18 +377,186 @@ public void testStopAndStartInsert() {
   @Test
   public void testRealTimeSchemaAndStopInsert() {

Review Comment:
   ```suggestion
     public void testRealTimeAndStopInsert() {
   ```



##########
server/src/main/java/org/apache/iotdb/db/sync/pipedata/queue/BufferedPipeDataQueue.java:
##########
@@ -428,7 +434,7 @@ public static List<PipeData> parsePipeLog(File file) throws IOException {
         pipeData.add(PipeData.deserialize(inputStream));
       }
     } catch (EOFException e) {
-      logger.info(String.format("Finish parsing pipeLog %s.", file.getPath()));
+      // logger.info(String.format("Finish parsing pipeLog %s.", file.getPath()));

Review Comment:
   delete if unnecessary



##########
server/src/main/java/org/apache/iotdb/db/sync/conf/SyncPathUtil.java:
##########
@@ -39,13 +39,13 @@ public static String getSenderPipeDir(String pipeName, long createTime) {
         + String.format("-%s-%d", pipeName, createTime);
   }
 
-  public static String getSenderHistoryPipeDataDir(String pipeName, long createTime) {
+  public static String getSenderHistoryPipeLogDir(String pipeName, long createTime) {
     return getSenderPipeDir(pipeName, createTime)

Review Comment:
   make directory structure on the sender side same as on the receiver side



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org