[GitHub] [netbeans] sdedic commented on a change in pull request #3828: Made GradleCommandLine aware of GradleVersion

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #3828:
URL: https://github.com/apache/netbeans/pull/3828#discussion_r831942423



##########
File path: extide/gradle/src/org/netbeans/modules/gradle/api/execute/GradleVersionRange.java
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.gradle.api.execute;
+
+import org.gradle.util.GradleVersion;
+
+/**
+ *

Review comment:
       Javadoc + `@since`

##########
File path: extide/gradle/src/org/netbeans/modules/gradle/loaders/LegacyProjectLoader.java
##########
@@ -194,7 +199,15 @@ private static GradleProject loadGradleProject(ReloadContext ctx, CancellationTo
         }
         return ret;
     }
-    
+
+    private static GradleVersion compatibleGradleVersion(Project prj) {

Review comment:
       Nitpick: Does this return a gradle version **compatible** with the current project, or the **configured** one ? I mean if the project does not specify anything, the current default version is returned regardless of project's structure

##########
File path: extide/gradle/src/org/netbeans/modules/gradle/loaders/ModelCache.java
##########
@@ -100,4 +109,12 @@ private void load() {
     public synchronized State getState() {
         return state;
     }
+
+    private GradleVersion compatibleGradleVersion() {

Review comment:
       Duplicate method - could it be moved to some module-private Util class ?

##########
File path: extide/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java
##########
@@ -88,58 +89,82 @@
      * @since 2.23
      */
     public interface GradleOptionItem {
+        /**
+         * Shall return {@code true} if the IDE supports this option item.
+         *
+         * @return {@code true} if this option is supported by the IDE
+         */
         boolean isSupported();
+        /**
+         * Shall return {@code true} if this option is supported by the provided
+         * GradleVersion.
+         * 
+         * @param ver the GradleVersion to check.
+         * @return {@code true} if the provided Gradle version supports this option.
+         */

Review comment:
       `@since`

##########
File path: extide/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java
##########
@@ -525,15 +596,22 @@ public ParametricArgument parse(String arg, Iterator<String> args) {
     }
     //</editor-fold>
 
+    final GradleVersion gradleVersion;
     final Set<Argument> arguments = new LinkedHashSet<>();
     final Set<String> tasks = new LinkedHashSet<>();
 
-    public GradleCommandLine(GradleCommandLine cmd) {
+    public GradleCommandLine(GradleVersion gradleVersion, GradleCommandLine cmd) {

Review comment:
       Javadoc + `@since`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists