You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/03/03 14:10:14 UTC
[GitHub] [ignite-3] zstan opened a new pull request #702: IGNITE-16645 Adopt bunch of tickets from AI-2
zstan opened a new pull request #702:
URL: https://github.com/apache/ignite-3/pull/702
IGNITE-16228 SetOp execution node cannot be rewinded.
IGNITE-16191 Unexpected result of COUNT with multiple parameters.
IGNITE-16354 Memory leak in RelOptCluster during mapping - append.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] zstan closed pull request #702: IGNITE-16645 Adopt bunch of tickets from AI-2
Posted by GitBox <gi...@apache.org>.
zstan closed pull request #702:
URL: https://github.com/apache/ignite-3/pull/702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #702: IGNITE-16645 Adopt bunch of tickets from AI-2
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #702:
URL: https://github.com/apache/ignite-3/pull/702#discussion_r819358683
##########
File path: modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/MappingQueryContext.java
##########
@@ -36,6 +44,18 @@ public MappingQueryContext(String locNodeId, long topVer) {
this.topVer = topVer;
}
+ /** Creates a cluster. */
+ RelOptCluster cluster() {
+ if (cluster == null) {
+ cluster = RelOptCluster.create(Commons.cluster().getPlanner(), Commons.cluster().getRexBuilder());
+ cluster.setMetadataProvider(new CachingRelMetadataProvider(IgniteMetadata.METADATA_PROVIDER,
+ Commons.cluster().getPlanner()));
+ cluster.setMetadataQuerySupplier(RelMetadataQueryEx::create);
Review comment:
Duplicate code. See BaseQueryContext.createCluster().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org