You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "0AyanamiRei (via GitHub)" <gi...@apache.org> on 2025/10/21 09:47:00 UTC
[PR] [fix](load) Fix the idempotence of the createPartition RPC, ensure consistent tablet replica information in one txn [doris]
0AyanamiRei opened a new pull request, #57197:
URL: https://github.com/apache/doris/pull/57197
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
During the load of a auto partition table, we will meet this case:
create partition rpc (need create partition : "2025-10-21" )
sink1 --------------------------------------------------------------------------------------> FE
create partition rpc (need create partition : "2025-10-21" )
sink2 --------------------------------------------------------------------------------------> FE
The FE's processing of these two RPCs is not atomic within a single import transaction, so we need to ensure the idempotence of this RPC.
But, if the FE processes the RPC from sink1 first, creating partition "2025-10-21", and then creates several tablets under it while selecting BEs for them. Assuming tablet1's replica is assigned to [BE-1].
----> This time, a tablet migration occurs (for load balancing), causing tablet1 move from [BE1] to [BE2]. When the FE processes the second RPC, it returns the post-migration information, resulting in inconsistent tablet1 replica distribution information observed by the two RPC initiators.
This indicates that the createPartition RPC is not idempotent.
Fix this caseļ¼
When the first RPC creates a partition and selects BE1 as the replica for tablet1, we record this information on a per-transaction basis. In the next RPC, we can simply return the recorded information.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) Fix the idempotence of the createPartition RPC, ensure consistent tablet replica information in one txn [doris]
Posted by "0AyanamiRei (via GitHub)" <gi...@apache.org>.
0AyanamiRei closed pull request #57197: [fix](load) Fix the idempotence of the createPartition RPC, ensure consistent tablet replica information in one txn
URL: https://github.com/apache/doris/pull/57197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) Fix the idempotence of the createPartition RPC, ensure consistent tablet replica information in one txn [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57197:
URL: https://github.com/apache/doris/pull/57197#issuecomment-3425685513
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org