You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by en...@apache.org on 2026/09/01 15:18:18 UTC

(superset) branch enxdev/fix/echarts updated: fix(echarts): correct inverted zoomable/non-zoomable description in getTemporalAxisTickConfig comment

This is an automated email from the ASF dual-hosted git repository.

EnxDev pushed a commit to branch enxdev/fix/echarts
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/enxdev/fix/echarts by this push:
     new eca1d754eb7 fix(echarts): correct inverted zoomable/non-zoomable description in getTemporalAxisTickConfig comment
eca1d754eb7 is described below

commit eca1d754eb7ae24ab23613ecf3b84718ecf19437
Author: Enzo Martellucci <en...@gmail.com>
AuthorDate: Tue Sep 1 17:17:57 2026 +0200

    fix(echarts): correct inverted zoomable/non-zoomable description in getTemporalAxisTickConfig comment
    
    Co-Authored-By: Claude Sonnet 5 <no...@anthropic.com>
---
 .../plugins/plugin-chart-echarts/src/utils/series.ts         | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts b/superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts
index 4c50d99a085..6ededf12ac3 100644
--- a/superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts
+++ b/superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts
@@ -1091,12 +1091,12 @@ export function capTickMarks(
  * MixedTimeseries. When temporalTickValues pins the axis to weekly buckets,
  * axisTick.customValues (what splitLine/gridlines follow) is downsampled to
  * avoid combing a long weekly range. axisLabel.customValues (what hideOverlap
- * thins from) uses the same capped set on a zoomable axis — zooming lets the
- * user reach any bucket, but customValues never recomputes on dataZoom, so a
- * capped set there would freeze the visible labels to the pre-zoom subset.
- * On a non-zoomable axis the full set is used instead, so a label surviving
- * hideOverlap thinning always lands on a real tick and gridline rather than a
- * capped-away bucket.
+ * thins from) uses the same capped set on a non-zoomable axis, so a label
+ * surviving hideOverlap thinning always lands on a real tick and gridline
+ * rather than a capped-away bucket. On a zoomable axis the full set is used
+ * instead — zooming lets the user reach any bucket, but customValues never
+ * recomputes on dataZoom, so a capped set there would freeze the visible
+ * labels to the pre-zoom subset.
  */
 export function getTemporalAxisTickConfig(
   temporalTickValues: number[] | undefined,