[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7746: make control.cidr dynamic

["weizhouapache (via GitHub)" <gi...@apache.org>]

weizhouapache commented on code in PR #7746:
URL: https://github.com/apache/cloudstack/pull/7746#discussion_r1291031697


##########
server/src/main/java/com/cloud/configuration/Config.java:
##########
@@ -885,14 +885,6 @@ public enum Config {
             "0",
             "Default disk I/O writerate in bytes per second allowed in User vm's disk.",
             null),
-    ControlCidr(
-            "Advanced",
-            ManagementServer.class,
-            String.class,
-            "control.cidr",
-            "169.254.0.0/16",
-            "Changes the cidr for the control network traffic.  Defaults to using link local.  Must be unique within pods",
-            null),
     ControlGateway("Advanced", ManagementServer.class, String.class, "control.gateway", "169.254.0.1", "gateway for the control network traffic", null),

Review Comment:
   @DaanHoogland 
   should ControlGateway be dynamic as well ?



##########
server/src/main/java/com/cloud/network/guru/ControlNetworkGuru.java:
##########
@@ -215,18 +215,6 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
 
         Map<String, String> dbParams = _configDao.getConfiguration(params);
 
-        _cidr = dbParams.get(Config.ControlCidr.toString());
-        if (_cidr == null) {
-            _cidr = NetUtils.getLinkLocalCIDR();
-        }
-
-        _gateway = dbParams.get(Config.ControlGateway.toString());
-        if (_gateway == null) {
-            _gateway = NetUtils.getLinkLocalGateway();
-        }

Review Comment:
   @DaanHoogland 
   should _gateway be set ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org