[GitHub] [storm] srdo commented on issue #3034: STORM-3422: TupleCaptureBolt is not thread-safe

[GitBox <gi...@apache.org>]

srdo commented on issue #3034: STORM-3422: TupleCaptureBolt is not thread-safe
URL: https://github.com/apache/storm/pull/3034#issuecomment-505580871
 
 
   I think I like the ListMultiMap approach a little better, since it's not as easy to forget to synchronize a reference to the map. I would also expect there to be some contention on the map field, as it will be updated by every tuple in the local topology.
   
   You're right that using a static field for this is a bit hacky. Best alternative I can think of would be creating a field in LocalCluster, and figuring out a way to share it with these bolts. It would probably be more complicated though. Either way, I don't think this is too bad, as the TupleCaptureBolt isn't supposed to be used outside a LocalCluster, and we can make sure to e.g. clear the field between topology submissions.
   
   If you can think of a good alternative, I don't think anyone would miss this bolt :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services