[GitHub] [arrow] icexelloss commented on a diff in pull request #34777: MINOR: [C++] Remove std::move when calling ProcessEmit and ProcessExtensionEmit

["icexelloss (via GitHub)" <gi...@apache.org>]

icexelloss commented on code in PR #34777:
URL: https://github.com/apache/arrow/pull/34777#discussion_r1153374376


##########
cpp/src/arrow/engine/substrait/expression_internal.h:
##########
@@ -39,11 +39,6 @@ ARROW_ENGINE_EXPORT
 Result<FieldRef> DirectReferenceFromProto(const substrait::Expression::FieldReference*,
                                           const ExtensionSet&, const ConversionOptions&);
 
-ARROW_ENGINE_EXPORT

Review Comment:
   Per this comment:
   https://github.com/apache/arrow/pull/34627#discussion_r1152715709
   
   I noticed and removed it here. Although unrelated to the original PR, I figured this is small enough change to piggy back here. If there are objection I can revert this change and put in separate PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org