You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/04/12 08:38:39 UTC
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request
#145: fix the future instance is replaced when the flush frequency is high
jixuan1989 commented on a change in pull request #145: fix the future instance is replaced when the flush frequency is high
URL: https://github.com/apache/incubator-iotdb/pull/145#discussion_r274811847
##########
File path: iotdb/src/main/java/org/apache/iotdb/db/engine/bufferwrite/BufferWriteProcessor.java
##########
@@ -332,16 +332,16 @@ private boolean flushTask(String displayMessage, long version) {
}
lastFlushTime = System.nanoTime();
// check value count
+ // waiting for the end of last flush operation.
+ try {
+ flushFuture.get();
+ } catch (InterruptedException | ExecutionException e) {
Review comment:
I think we need to throw it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services