You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/30 14:19:14 UTC

[GitHub] [nuttx] PetervdPerk-NXP opened a new pull request, #7737: S32K3XX RAM fixes

PetervdPerk-NXP opened a new pull request, #7737:
URL: https://github.com/apache/nuttx/pull/7737

   ## Summary
   Fixes various S32K3 RAM related issues.
   
   - Correct ECC initialization of full RAM controller
   - Configuration of MPU when Dcache is enabled to fix ARM errata 1267980
   - Linker config S32K3X4-EVB fixed
   - Other: LPUART don't TX invert when singlewire is enabled.
   
   ## Impact
   Fixes undefined behavior when dcache was enabled
   
   ## Testing
   Test on MR-CANHUBK3 board
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #7737: S32K3XX RAM fixes

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7737:
URL: https://github.com/apache/nuttx/pull/7737#discussion_r1037579763


##########
arch/arm/src/s32k3xx/Kconfig:
##########
@@ -193,6 +193,14 @@ config S32K3XX_HAVE_ENET
 	select ARCH_PHY_INTERRUPT
 	select ARCH_HAVE_NETDEV_STATISTICS
 
+# Select MPU when D-cache is enabled for ARM errata 1624041
+
+config S32K3XX_NEEDS_MPU
+    bool
+    default y
+	depends on ARMV7M_DCACHE
+	select ARM_MPU

Review Comment:
   Please change to TABs in Kconfig files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] davids5 merged pull request #7737: S32K3XX RAM fixes

Posted by GitBox <gi...@apache.org>.
davids5 merged PR #7737:
URL: https://github.com/apache/nuttx/pull/7737


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] PetervdPerk-NXP commented on pull request #7737: S32K3XX RAM fixes

Posted by GitBox <gi...@apache.org>.
PetervdPerk-NXP commented on PR #7737:
URL: https://github.com/apache/nuttx/pull/7737#issuecomment-1332406420

   Simply when singlewire is enabled and txinvert is enabled the LPUART stops working. When disabling txinvert and keeping rxinvert it's seems to be working fine. But I've only tested with a undirectional FlySky Radio.
   
   Regarding testing, I've tested on both master NuttX and PX4 NuttX (10.3+ version) running moderate load and some endurance tests for couple hours. On master nuttx I've used the mm command to test both sram and dtcm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org