You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Andreas Veithen (JIRA)" <ji...@apache.org> on 2009/08/09 00:13:14 UTC
[jira] Commented: (WSCOMMONS-470) SMS Transport
[ https://issues.apache.org/jira/browse/WSCOMMONS-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740983#action_12740983 ]
Andreas Veithen commented on WSCOMMONS-470:
-------------------------------------------
Why is SMSManager implemented as a singleton? I would expect that in the same Axis2 instance, I can mix the implementations, e.g. SMPP for outgoing messages and a GSM modem for incoming messages.
> SMS Transport
> -------------
>
> Key: WSCOMMONS-470
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-470
> Project: WS-Commons
> Issue Type: New Feature
> Components: Transport
> Affects Versions: Transports 1.1
> Environment: All
> Reporter: Charith Dhanushka Wickramarachchi
> Priority: Minor
> Fix For: Transports 1.1
>
> Attachments: 14-07-2009-sms-transport.patch, 25-06-2009-sms-transport.patch, OutPutService.aar, sampleInOutService.aar, sms-transport-2009-06-04.patch, sms-transport-22-06-2009.patch, sms-transport-25-05-2009.patch, sms-transport-28-05-2009.patch
>
>
> Hi,
> I'm doing the SMS Transport for Axis2 as my google summer of code 2009 project.
> SMS Transport for Apache Axis2 is a project focusing on implementing a SMPP protocol support for Axis2java (And also it will able be used in Apache Synapse too Since Synapse uses the same axis2Transports ) by which Axis2 will be able to communicate with SMSCs (Short message service centers) or Any other Message centers that support SMPP . And also in this project it will make enable Axis2/Synapse to communicate with Simple GSM modems.
> following is the link to the project proposal
> http://wiki.apache.org/general/charith/gsoc2009/axis2transportProposal
> I'll be providing patches regularly while I'm developing the Transport
> Thank you,
> Charith
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (WSCOMMONS-470) SMS Transport
Posted by Charith Wickramarachchi <ch...@gmail.com>.
I will do that change in https://issues.apache.org/jira/browse/WSCOMMONS-495
thanks,
Charith
On Sun, Aug 9, 2009 at 10:10 PM, Andreas Veithen
<an...@gmail.com>wrote:
> I think you should get rid of the singletons because they have a state
> that is initialized by the transport and depends on the configuration
> of the transport. This only works if you assume that only a single
> instance of the transport exists. This may be the case in most
> scenarios, but there is no guarantee.
>
> Andreas
>
> On Sun, Aug 9, 2009 at 16:43, Charith
> Wickramarachchi<ch...@gmail.com> wrote:
> > Hi Andreas,
> >
> > Its good that you bring that use case of mixing implementations.I'll add
> > that feature to the code.But Still i think SMSManager need to be a
> > singleton.Since it manages the sending and receiving on the Axis2
> layer.And
> > note that there are Implementation Managers for the respective
> > implimentations.
> >
> > thanks,
> > charith
> >
> > On Sun, Aug 9, 2009 at 3:43 AM, Andreas Veithen (JIRA) <jira@apache.org
> >wrote:
> >
> >>
> >> [
> >>
> https://issues.apache.org/jira/browse/WSCOMMONS-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740983#action_12740983
> ]
> >>
> >> Andreas Veithen commented on WSCOMMONS-470:
> >> -------------------------------------------
> >>
> >> Why is SMSManager implemented as a singleton? I would expect that in the
> >> same Axis2 instance, I can mix the implementations, e.g. SMPP for
> outgoing
> >> messages and a GSM modem for incoming messages.
> >>
> >> > SMS Transport
> >> > -------------
> >> >
> >> > Key: WSCOMMONS-470
> >> > URL:
> https://issues.apache.org/jira/browse/WSCOMMONS-470
> >> > Project: WS-Commons
> >> > Issue Type: New Feature
> >> > Components: Transport
> >> > Affects Versions: Transports 1.1
> >> > Environment: All
> >> > Reporter: Charith Dhanushka Wickramarachchi
> >> > Priority: Minor
> >> > Fix For: Transports 1.1
> >> >
> >> > Attachments: 14-07-2009-sms-transport.patch,
> >> 25-06-2009-sms-transport.patch, OutPutService.aar,
> sampleInOutService.aar,
> >> sms-transport-2009-06-04.patch, sms-transport-22-06-2009.patch,
> >> sms-transport-25-05-2009.patch, sms-transport-28-05-2009.patch
> >> >
> >> >
> >> > Hi,
> >> > I'm doing the SMS Transport for Axis2 as my google summer of code 2009
> >> project.
> >> > SMS Transport for Apache Axis2 is a project focusing on implementing a
> >> SMPP protocol support for Axis2java (And also it will able be used in
> Apache
> >> Synapse too Since Synapse uses the same axis2Transports ) by which Axis2
> >> will be able to communicate with SMSCs (Short message service centers)
> or
> >> Any other Message centers that support SMPP . And also in this project
> it
> >> will make enable Axis2/Synapse to communicate with Simple GSM modems.
> >> > following is the link to the project proposal
> >> >
> http://wiki.apache.org/general/charith/gsoc2009/axis2transportProposal
> >> > I'll be providing patches regularly while I'm developing the Transport
> >> > Thank you,
> >> > Charith
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> -
> >> You can reply to this email to add a comment to the issue online.
> >>
> >>
> >
> >
> > --
> > Charith Dhanushka Wickramarachchi
> > http://charithwiki.blogspot.com/
> >
>
--
Charith Dhanushka Wickramarachchi
http://charithwiki.blogspot.com/
Re: [jira] Commented: (WSCOMMONS-470) SMS Transport
Posted by Andreas Veithen <an...@gmail.com>.
I think you should get rid of the singletons because they have a state
that is initialized by the transport and depends on the configuration
of the transport. This only works if you assume that only a single
instance of the transport exists. This may be the case in most
scenarios, but there is no guarantee.
Andreas
On Sun, Aug 9, 2009 at 16:43, Charith
Wickramarachchi<ch...@gmail.com> wrote:
> Hi Andreas,
>
> Its good that you bring that use case of mixing implementations.I'll add
> that feature to the code.But Still i think SMSManager need to be a
> singleton.Since it manages the sending and receiving on the Axis2 layer.And
> note that there are Implementation Managers for the respective
> implimentations.
>
> thanks,
> charith
>
> On Sun, Aug 9, 2009 at 3:43 AM, Andreas Veithen (JIRA) <ji...@apache.org>wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/WSCOMMONS-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740983#action_12740983]
>>
>> Andreas Veithen commented on WSCOMMONS-470:
>> -------------------------------------------
>>
>> Why is SMSManager implemented as a singleton? I would expect that in the
>> same Axis2 instance, I can mix the implementations, e.g. SMPP for outgoing
>> messages and a GSM modem for incoming messages.
>>
>> > SMS Transport
>> > -------------
>> >
>> > Key: WSCOMMONS-470
>> > URL: https://issues.apache.org/jira/browse/WSCOMMONS-470
>> > Project: WS-Commons
>> > Issue Type: New Feature
>> > Components: Transport
>> > Affects Versions: Transports 1.1
>> > Environment: All
>> > Reporter: Charith Dhanushka Wickramarachchi
>> > Priority: Minor
>> > Fix For: Transports 1.1
>> >
>> > Attachments: 14-07-2009-sms-transport.patch,
>> 25-06-2009-sms-transport.patch, OutPutService.aar, sampleInOutService.aar,
>> sms-transport-2009-06-04.patch, sms-transport-22-06-2009.patch,
>> sms-transport-25-05-2009.patch, sms-transport-28-05-2009.patch
>> >
>> >
>> > Hi,
>> > I'm doing the SMS Transport for Axis2 as my google summer of code 2009
>> project.
>> > SMS Transport for Apache Axis2 is a project focusing on implementing a
>> SMPP protocol support for Axis2java (And also it will able be used in Apache
>> Synapse too Since Synapse uses the same axis2Transports ) by which Axis2
>> will be able to communicate with SMSCs (Short message service centers) or
>> Any other Message centers that support SMPP . And also in this project it
>> will make enable Axis2/Synapse to communicate with Simple GSM modems.
>> > following is the link to the project proposal
>> > http://wiki.apache.org/general/charith/gsoc2009/axis2transportProposal
>> > I'll be providing patches regularly while I'm developing the Transport
>> > Thank you,
>> > Charith
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
> --
> Charith Dhanushka Wickramarachchi
> http://charithwiki.blogspot.com/
>
Re: [jira] Commented: (WSCOMMONS-470) SMS Transport
Posted by Charith Wickramarachchi <ch...@gmail.com>.
Hi Andreas,
Its good that you bring that use case of mixing implementations.I'll add
that feature to the code.But Still i think SMSManager need to be a
singleton.Since it manages the sending and receiving on the Axis2 layer.And
note that there are Implementation Managers for the respective
implimentations.
thanks,
charith
On Sun, Aug 9, 2009 at 3:43 AM, Andreas Veithen (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/WSCOMMONS-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740983#action_12740983]
>
> Andreas Veithen commented on WSCOMMONS-470:
> -------------------------------------------
>
> Why is SMSManager implemented as a singleton? I would expect that in the
> same Axis2 instance, I can mix the implementations, e.g. SMPP for outgoing
> messages and a GSM modem for incoming messages.
>
> > SMS Transport
> > -------------
> >
> > Key: WSCOMMONS-470
> > URL: https://issues.apache.org/jira/browse/WSCOMMONS-470
> > Project: WS-Commons
> > Issue Type: New Feature
> > Components: Transport
> > Affects Versions: Transports 1.1
> > Environment: All
> > Reporter: Charith Dhanushka Wickramarachchi
> > Priority: Minor
> > Fix For: Transports 1.1
> >
> > Attachments: 14-07-2009-sms-transport.patch,
> 25-06-2009-sms-transport.patch, OutPutService.aar, sampleInOutService.aar,
> sms-transport-2009-06-04.patch, sms-transport-22-06-2009.patch,
> sms-transport-25-05-2009.patch, sms-transport-28-05-2009.patch
> >
> >
> > Hi,
> > I'm doing the SMS Transport for Axis2 as my google summer of code 2009
> project.
> > SMS Transport for Apache Axis2 is a project focusing on implementing a
> SMPP protocol support for Axis2java (And also it will able be used in Apache
> Synapse too Since Synapse uses the same axis2Transports ) by which Axis2
> will be able to communicate with SMSCs (Short message service centers) or
> Any other Message centers that support SMPP . And also in this project it
> will make enable Axis2/Synapse to communicate with Simple GSM modems.
> > following is the link to the project proposal
> > http://wiki.apache.org/general/charith/gsoc2009/axis2transportProposal
> > I'll be providing patches regularly while I'm developing the Transport
> > Thank you,
> > Charith
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
Charith Dhanushka Wickramarachchi
http://charithwiki.blogspot.com/