You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/08 12:40:41 UTC
[GitHub] [zookeeper] maoling commented on a change in pull request #1574: ZOOKEEPER-4054: Make prometheus listen host can configure
maoling commented on a change in pull request #1574:
URL: https://github.com/apache/zookeeper/pull/1574#discussion_r589392017
##########
File path: zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/test/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProviderTest.java
##########
@@ -56,6 +56,7 @@ public void setup() throws Exception {
CollectorRegistry.defaultRegistry.clear();
provider = new PrometheusMetricsProvider();
Properties configuration = new Properties();
+ configuration.setProperty("httpHost", "127.0.0.1"); // local host for test
configuration.setProperty("httpPort", "0"); // ephemeral port
Review comment:
PortAssignment.unique()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org