You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Li Jing Qin (JIRA)" <ji...@apache.org> on 2010/03/11 10:46:27 UTC
[jira] Created: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
[classlib][luni]ObjectInputStream has unreached code.
-----------------------------------------------------
Key: HARMONY-6469
URL: https://issues.apache.org/jira/browse/HARMONY-6469
Project: Harmony
Issue Type: Bug
Reporter: Li Jing Qin
Fix For: 5.0M14
Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison updated HARMONY-6469:
---------------------------------
Fix Version/s: (was: 5.0M15)
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909109#action_12909109 ]
Li Jing Qin commented on HARMONY-6469:
--------------------------------------
Sorry it should be with or without the patch.
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Assignee: Mark Hindess
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2, HARMONY-6469.diff
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908841#action_12908841 ]
Li Jing Qin commented on HARMONY-6469:
--------------------------------------
Mark, without the patch, in the very clear repos, beans unit test still got vm crash. This should be some regression. What's the situation in your site?
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Assignee: Mark Hindess
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2, HARMONY-6469.diff
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908726#action_12908726 ]
Li Jing Qin commented on HARMONY-6469:
--------------------------------------
Mark, I have applied you patch on my windows repos. The test result is ok. I will try to get a clean linux repos and try your patch again.
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Assignee: Mark Hindess
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2, HARMONY-6469.diff
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909108#action_12909108 ]
Li Jing Qin commented on HARMONY-6469:
--------------------------------------
Mark. I have tested on a not so clear repos. The beans junit test cases passed w/o the patch.
With git svn info:
URL: https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk
Repository Root: https://svn.apache.org/repos/asf
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 996687
Node Kind: directory
Schedule: normal
Last Changed Author: jessewilson
Last Changed Rev: 996687
Last Changed Date: 2010-09-14 04:58:14 +0800 (Tue, 14 Sep 2010)
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Assignee: Mark Hindess
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2, HARMONY-6469.diff
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6469:
---------------------------------
Attachment: findbug-luni-ObjectInputStream.diff
This patch remove the unreached code and unused null check.
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Fix For: 5.0M14
>
> Attachments: findbug-luni-ObjectInputStream.diff
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908897#action_12908897 ]
Mark Hindess commented on HARMONY-6469:
---------------------------------------
It is quite consistent. beans test crashes with the patch. beans test passes without it. I'll try to take a better look at the crash when I get a moment.
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Assignee: Mark Hindess
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2, HARMONY-6469.diff
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess reassigned HARMONY-6469:
-------------------------------------
Assignee: Mark Hindess
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Assignee: Mark Hindess
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6469:
---------------------------------
Attachment: findbug-luni-ObjectInputStream.diff.v2
A more clean refactor. Remove the used setBack local flag. Test case result on linux remain the same as non-refactor version result.
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Fix For: 5.0M14
>
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878920#action_12878920 ]
Tim Ellison commented on HARMONY-6469:
--------------------------------------
This patch does not apply cleanly to the current implementation. Please can you refresh it?
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Fix For: 5.0M15
>
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess updated HARMONY-6469:
----------------------------------
Fix Version/s: 5.0M15
(was: 5.0M14)
Thanks for this contribution. Since it is neither a regression nor bug fix, I am deferring applying it until the next release. Sorry.
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Fix For: 5.0M15
>
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6469) [classlib][luni]ObjectInputStream
has unreached code.
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess updated HARMONY-6469:
----------------------------------
Attachment: HARMONY-6469.diff
The patch looked trivial so I tried updating it (rolling back with "svn up -r '{2010-03-12}", applying the patch, creating a new one with "svn diff -x -w", and applying that to latest trunk). However when I apply it I see test crashes with DRLVM in org.apache.harmony.luni.tests.java.io.OutputStreamTesterTest, java.beans.ArrayPersistenceDelegateTest, etc.
Li Jing Qin, what am I missing can you update the patch please?
> [classlib][luni]ObjectInputStream has unreached code.
> -----------------------------------------------------
>
> Key: HARMONY-6469
> URL: https://issues.apache.org/jira/browse/HARMONY-6469
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Assignee: Mark Hindess
> Attachments: findbug-luni-ObjectInputStream.diff, findbug-luni-ObjectInputStream.diff.v2, HARMONY-6469.diff
>
>
> Since the Object has been called before, the null check is unused afterwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.