You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (Jira)" <ji...@apache.org> on 2019/10/09 23:49:00 UTC
[jira] [Comment Edited] (THRIFT-4951) Remove tests for deprecated
senum base type
[ https://issues.apache.org/jira/browse/THRIFT-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948075#comment-16948075 ]
Jens Geyer edited comment on THRIFT-4951 at 10/9/19 11:48 PM:
--------------------------------------------------------------
FYI, I just reverted this.
We should first do our homework and check if fbthrift still supports it, for sake of compatibility. Could be worth filing an fbthrift ticket, if they still have it, so we get rid of it on both ends.
And while we're at it, we could also do the same for {{slist}}
[~pengzhouhu]: Would you mind to follow up on this?
was (Author: jensg):
FYI, I just reverted this.
We should first do our homework and check if fbthrift still supports it, for sake of compatibility. Could be worth filing an fbthrift ticket, if they still have it, so we get rid of it on both ends.
And while we're at it, we could also do the same for {{slist}}
> Remove tests for deprecated senum base type
> -------------------------------------------
>
> Key: THRIFT-4951
> URL: https://issues.apache.org/jira/browse/THRIFT-4951
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Affects Versions: 0.13.0
> Environment: thrift-master
> Reporter: pengzhouhu
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> -clean up unsupported senum base types from 0.9.1-
> *Remove tests for deprecated senum base type*
> refer to : THRIFT-2003(https://issues.apache.org/jira/browse/THRIFT-2003) - Deprecate senum
--
This message was sent by Atlassian Jira
(v8.3.4#803005)