You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/07/24 07:30:38 UTC

[GitHub] codecov-io edited a comment on issue #3873: Cleanup SPIs, move ActivationStore to whisk.core.database.

codecov-io edited a comment on issue #3873: Cleanup SPIs, move ActivationStore to whisk.core.database.
URL: https://github.com/apache/incubator-openwhisk/pull/3873#issuecomment-404643337
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873?src=pr&el=h1) Report
   > Merging [#3873](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/5694f38d000bd2c631a9fe754422dd960bc5d88c?src=pr&el=desc) will **decrease** coverage by `4.78%`.
   > The diff coverage is `10%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/graphs/tree.svg?height=150&width=650&token=l0YmsiSAso&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #3873      +/-   ##
   ==========================================
   - Coverage   75.82%   71.03%   -4.79%     
   ==========================================
     Files         145      145              
     Lines        6919     6919              
     Branches      409      415       +6     
   ==========================================
   - Hits         5246     4915     -331     
   - Misses       1673     2004     +331
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==) | `26.66% <ø> (ø)` | :arrow_up: |
   | [...hisk/core/controller/actions/SequenceActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1NlcXVlbmNlQWN0aW9ucy5zY2FsYQ==) | `31.42% <ø> (ø)` | :arrow_up: |
   | [...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh) | `0% <ø> (ø)` | :arrow_up: |
   | [.../whisk/core/database/ArtifactActivationStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXJ0aWZhY3RBY3RpdmF0aW9uU3RvcmUuc2NhbGE=) | `92.85% <ø> (ø)` | |
   | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.59% <ø> (ø)` | :arrow_up: |
   | [...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh) | `61.81% <ø> (ø)` | :arrow_up: |
   | [...n/scala/whisk/core/loadBalancer/LoadBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xvYWRCYWxhbmNlci5zY2FsYQ==) | `50% <ø> (ø)` | :arrow_up: |
   | [...main/scala/whisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==) | `96.61% <ø> (ø)` | :arrow_up: |
   | [...rc/main/scala/whisk/core/controller/Triggers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9UcmlnZ2Vycy5zY2FsYQ==) | `80.88% <ø> (ø)` | :arrow_up: |
   | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `31.6% <ø> (ø)` | :arrow_up: |
   | ... and [17 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873?src=pr&el=footer). Last update [5694f38...5ca15e8](https://codecov.io/gh/apache/incubator-openwhisk/pull/3873?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services