[GitHub] [ignite-3] alievmirza commented on a diff in pull request #1932: IGNITE-18954 add the ability to filter node's attributes

["alievmirza (via GitHub)" <gi...@apache.org>]

alievmirza commented on code in PR #1932:
URL: https://github.com/apache/ignite-3/pull/1932#discussion_r1164219413


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZonesUtil.java:
##########
@@ -370,4 +372,42 @@ public static DistributionZoneConfiguration getZoneById(DistributionZonesConfigu
 
         return null;
     }
+
+    /**
+     * Check if {@code nodeAttributes} satisfy the {@code filter}.
+     *
+     * @param nodeAttributes Key value map of node's attributes.
+     * @param filter Valid {@link JsonPath} filter of JSON fields.
+     * @return True if at least one value from {@code nodeAttributes} satisfy {@code filter}, false otherwise.

Review Comment:
   agreed, javadoc a bit unclear, I'll rewrite



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org