DO NOT REPLY [Bug 38994] New: - ap_graceful_stop_signalled() always returns "0" from prefork.c

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38994>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38994

           Summary: ap_graceful_stop_signalled() always returns "0" from
                    prefork.c
           Product: Apache httpd-2
           Version: 2.0.55
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: prefork
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: lavr@ncbi.nlm.nih.gov


mpm/prefork/prefork.c implements ap_graceful_stop_signalled() as
the following (BTW, same goes true for mpm/netware/mpm_netware.c but
I don't use that at all):

    int ap_graceful_stop_signalled(void)
    {
        /* not ever called anymore... */
        return 0;
    }
 
Not only the comment is wrong (the function IS actually called from
modules/core/http_core.c), this "implemetation" goes out of
sync with implementations of the same call in all other MPMs, so
any code that depends on whether the restart is graceful or
forced, will fail to detect this, yet the fix is the simplest ever:
just a return of "is_graceful" instead of plain "0" will do the job.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org