You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/11 00:11:31 UTC
[GitHub] [iceberg] kbendick opened a new pull request #1579: Fix off by one error in TestHiveIcebergFilterFactory#testDateType
kbendick opened a new pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579
For me, the test `TestHiveIcebergFilterFactory#testDateType` is failing.
The predicate filter is testing for equality on dates being "2015-11-12".
There's an off by one error, where the value of `gmtDate` that is returned from the existing way of computing it is 2015-11-11 and not 2015-11-12. This is possibly due to the timezone of my computer, but the test is failing when running locally in California.
I've simply changed the test to use `Date.valueOf("2015-11-12")`, which matches the `Literal.of("2015-11-12")` more closely anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick edited a comment on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707456979
I added a bunch of temporary commits and finally got CI to work, but then reset hard back to the old spot and now it shows as failing again.
Here's the CI run when it did pass: https://travis-ci.org/github/apache/iceberg/builds/735230278
I think upping the ulimit when running the tests might possibly help? Hard for me to say without being able to access the travis configuration (I'm not even sure my adding `ulimit -n 3000` in a `before_script` block had any effect because I can't quite see it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1579: Fix possibly flakey test in TestHiveIcebergFilterFactory#testDateType
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-706669364
I spoke to Shardul offline and got confirmation that this test is failing on their local machine as well.
Admittedly it's not failing on CI, but it's not the developer experience for anybody who runs the build and test themselves vs offloading to Travis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1579: Fix possibly flakey test in TestHiveIcebergFilterFactory#testDateType
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#discussion_r503394765
##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergFilterFactory.java
##########
@@ -207,8 +206,8 @@ public void testBooleanType() {
@Test
public void testDateType() {
SearchArgument.Builder builder = SearchArgumentFactory.newBuilder();
- Date gmtDate = new Date(LocalDate.of(2015, 11, 12).atStartOfDay(ZoneOffset.UTC).toInstant().toEpochMilli());
- SearchArgument arg = builder.startAnd().equals("date", PredicateLeaf.Type.DATE, gmtDate).end().build();
+ Date date = Date.valueOf("2015-11-12");
Review comment:
We need to avoid using classes that will change behavior based on time zone to parse the value of a date or timestamp. This method was purposely not used. The problem here is probably that although the instant value is correct, the Date uses the JVM time zone somehow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707852952
Since the test failures are unrelated, I'm going to merge this fix. Thanks @kbendick!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick edited a comment on pull request #1579: Fix possibly flakey test in TestHiveIcebergFilterFactory#testDateType
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-706669364
I spoke to Shardul offline and got confirmation that this test is failing on their local machine as well.
Admittedly it's not failing on CI, but it's not the best developer experience for anybody who runs `./gradlew clean build` and their local machine isn't configured the same as Travis (which is probably in UTC already).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707441290
> The toString representation from Date is in the local zone. I don't think that it matters what the toString shows, as long as the actual value it gets converted to for Iceberg is correct. That's because Hive is responsible for translating "2020-11-12" into a Date however it chooses, but Iceberg should always use the date of the instant in UTC.
Good point. Been a while since I've debug printed a Date manually like that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707336690
Ok. I reverted the unit test changes and updated the code. So it seems to be passing for me now too.
However, when I run this, the value of `gmtDate` is still `2015-11-11` if I print it right after it's created.
The values now for expected and actual are both 16751. I also printed out the Date value generated in `leafToLiteral` and it is also `2015-11-11`.
Is this expected due to the use of exclusive bounds or something?
```
gmtDate:2015-11-11
The constant date is 2015-11-11
The date in leafToLiteral using daysFromDate is 16751
expected:ref(name="date") == 16751
actual:ref(name="date") == 16751
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707347685
The toString representation from Date is in the local zone. I don't think that it matters what the toString shows, as long as the actual value it gets converted to for Iceberg is correct. That's because Hive is responsible for translating "2020-11-12" into a Date however it chooses, but Iceberg should always use the date of the instant in UTC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707436205
The CI failed for Java 8 a transient HMS connection issue similar to this one. I get these intermittently on my local but have never had them on CI.
```
org.apache.iceberg.mr.hive.TestHiveIcebergStorageHandlerWithHiveCatalog > testScanTableORC FAILED
java.lang.IllegalArgumentException: Failed to executeQuery Hive query SHOW TABLES: Error while compiling statement: FAILED: SemanticException org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: FAILED: SemanticException org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.hadoop.hive.ql.parse.SemanticException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.hadoop.hive.ql.metadata.HiveException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
java.net.SocketException: Broken pipe (Write failed)
org.apache.hadoop.hive.ql.metadata.HiveException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
java.net.SocketException: Broken pipe (Write failed)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1579: Fix flakey test in TestHiveIcebergFilterFactory#testDateType
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-706656617
cc @shardulm94 for your thoughts on this and whether or not you experience this problem on your local machine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1579: Fix possibly flakey test in TestHiveIcebergFilterFactory#testDateType
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707296047
Cool. I can push a fix using your change after work today 👍 . @rdblue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #1579: Fix possibly flakey test in TestHiveIcebergFilterFactory#testDateType
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#discussion_r503512635
##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergFilterFactory.java
##########
@@ -207,8 +206,8 @@ public void testBooleanType() {
@Test
public void testDateType() {
SearchArgument.Builder builder = SearchArgumentFactory.newBuilder();
- Date gmtDate = new Date(LocalDate.of(2015, 11, 12).atStartOfDay(ZoneOffset.UTC).toInstant().toEpochMilli());
- SearchArgument arg = builder.startAnd().equals("date", PredicateLeaf.Type.DATE, gmtDate).end().build();
+ Date date = Date.valueOf("2015-11-12");
Review comment:
I reverted this to the previous code. It's running on my local now with the patch for `daysFromDate`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #1579: Fix possibly flakey test in TestHiveIcebergFilterFactory#testDateType
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#discussion_r503483147
##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergFilterFactory.java
##########
@@ -207,8 +206,8 @@ public void testBooleanType() {
@Test
public void testDateType() {
SearchArgument.Builder builder = SearchArgumentFactory.newBuilder();
- Date gmtDate = new Date(LocalDate.of(2015, 11, 12).atStartOfDay(ZoneOffset.UTC).toInstant().toEpochMilli());
- SearchArgument arg = builder.startAnd().equals("date", PredicateLeaf.Type.DATE, gmtDate).end().build();
+ Date date = Date.valueOf("2015-11-12");
Review comment:
I had a feeling this method was purposely not used, but I wasn't sure of a better option so I figured I'd open the PR and then let somebody point it out. I also figured that the flakey test was indicative of more than just a flakey test. I'll apply your suggestions this evening after work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707852558
@pvary and @marton-bod, looks like we have some flaky behavior with Hive tests. Here's the failure from @kbendick's comment above:
> ```
> org.apache.iceberg.mr.hive.TestHiveIcebergStorageHandlerWithHiveCatalog > testJoinTablesParquet FAILED
> java.lang.IllegalArgumentException: Failed to executeQuery Hive query SHOW TABLES: Error while compiling statement: FAILED: SemanticException org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
> Caused by:
> org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: FAILED: SemanticException org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
> Caused by:
> org.apache.hadoop.hive.ql.parse.SemanticException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
> Caused by:
> org.apache.hadoop.hive.ql.metadata.HiveException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
> Caused by:
> org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
> Caused by:
> java.net.SocketException: Broken pipe (Write failed)
> org.apache.hadoop.hive.ql.metadata.HiveException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
> Caused by:
> org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
> Caused by:
> java.net.SocketException: Broken pipe (Write failed)
> ```
This is probably caused by too many open connections at once. Can you help us double-check the use of client pools in Hive? Are client pools reused across tests with HiveRunner?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707456979
I added a bunch of temporary commits and finally got CI to work, but then reset hard back to the old spot and now it shows as failing again.
I think upping the ulimit when running the tests might possibly help?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick edited a comment on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707436205
The CI failed for Java 8 a transient HMS connection issue similar to this one. I get these intermittently on my local but have never had them on CI.
```
org.apache.iceberg.mr.hive.TestHiveIcebergStorageHandlerWithHiveCatalog > testJoinTablesParquet FAILED
java.lang.IllegalArgumentException: Failed to executeQuery Hive query SHOW TABLES: Error while compiling statement: FAILED: SemanticException org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: FAILED: SemanticException org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.hadoop.hive.ql.parse.SemanticException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.hadoop.hive.ql.metadata.HiveException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
java.net.SocketException: Broken pipe (Write failed)
org.apache.hadoop.hive.ql.metadata.HiveException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
java.net.SocketException: Broken pipe (Write failed)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1579: Fix possibly flakey test in TestHiveIcebergFilterFactory#testDateType
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707222919
The problem here is that `HiveIcebergFilterFactory.daysFromDate` calls `date.toLocalDate`, which is zone-dependent. So although we set the underlying date value correctly, it is corrupted by calling `toLocalDate`. We need to fix that method to translate correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick edited a comment on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707436205
The CI failed for Java 8 a transient HMS connection issue similar to this one. I've gotten these intermittently on my local for a while now, but have never had them on CI until now. Now I can't seem to get them to be stable and pass, though they pass locally.
```
org.apache.iceberg.mr.hive.TestHiveIcebergStorageHandlerWithHiveCatalog > testJoinTablesParquet FAILED
java.lang.IllegalArgumentException: Failed to executeQuery Hive query SHOW TABLES: Error while compiling statement: FAILED: SemanticException org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: FAILED: SemanticException org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.hadoop.hive.ql.parse.SemanticException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.hadoop.hive.ql.metadata.HiveException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
java.net.SocketException: Broken pipe (Write failed)
org.apache.hadoop.hive.ql.metadata.HiveException: org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
org.apache.thrift.transport.TTransportException: java.net.SocketException: Broken pipe (Write failed)
Caused by:
java.net.SocketException: Broken pipe (Write failed)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick edited a comment on pull request #1579: Fix possibly flakey test in TestHiveIcebergFilterFactory#testDateType
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-706669364
I spoke to Shardul offline and got confirmation that this test is failing on their local machine as well.
Admittedly it's not failing on CI, but it's not the best developer experience in my opinion for anybody who runs `./gradlew clean build` to get a build failure if their local machine isn't configured the same as Travis (which is probably in UTC already).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707460126
I think this might be why it's failing: https://github.com/apache/iceberg/pull/1585
The update to the test memory in that PR is possibly not in my branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue edited a comment on pull request #1579: Fix possibly flakey test in TestHiveIcebergFilterFactory#testDateType
Posted by GitBox <gi...@apache.org>.
rdblue edited a comment on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707222919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org