You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by bo...@apache.org on 2026/02/22 03:16:58 UTC
(grails-core) 02/08: Remove unused fields from ComponentBinder
This is an automated email from the ASF dual-hosted git repository.
borinquenkid pushed a commit to branch 8.0.x-hibernate7
in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit b43a4a03bc6e8b2f2088de18a4a0f2a227d4cdfa
Author: Walter Duque de Estrada <wb...@mac.com>
AuthorDate: Sat Feb 21 13:49:17 2026 -0600
Remove unused fields from ComponentBinder
---
.../cfg/domainbinding/binder/ComponentBinder.java | 22 ----------------------
.../domainbinding/binder/GrailsDomainBinder.java | 6 ------
.../cfg/domainbinding/CollectionBinderSpec.groovy | 6 ------
.../cfg/domainbinding/ComponentBinderSpec.groovy | 19 -------------------
.../domainbinding/GrailsPropertyBinderSpec.groovy | 6 ------
.../secondpass/ListSecondPassBinderSpec.groovy | 6 ------
.../secondpass/MapSecondPassBinderSpec.groovy | 6 ------
7 files changed, 71 deletions(-)
diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ComponentBinder.java b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ComponentBinder.java
index 045b360512..2721c5c39b 100644
--- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ComponentBinder.java
+++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ComponentBinder.java
@@ -24,48 +24,26 @@ import org.grails.orm.hibernate.cfg.MappingCacheHolder;
import org.grails.orm.hibernate.cfg.domainbinding.hibernate.GrailsHibernatePersistentEntity;
import org.grails.orm.hibernate.cfg.domainbinding.hibernate.GrailsHibernatePersistentProperty;
import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateEmbeddedProperty;
-import org.grails.orm.hibernate.cfg.domainbinding.util.ColumnNameForPropertyAndPathFetcher;
import org.hibernate.boot.spi.InFlightMetadataCollector;
import org.hibernate.boot.spi.MetadataBuildingContext;
import org.hibernate.mapping.Component;
import org.hibernate.mapping.PersistentClass;
import org.hibernate.mapping.Table;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
public class ComponentBinder {
- private static final Logger LOG = LoggerFactory.getLogger(ComponentBinder.class);
private final MetadataBuildingContext metadataBuildingContext;
private final MappingCacheHolder mappingCacheHolder;
- private final EnumTypeBinder enumTypeBinder;
- private final CollectionBinder collectionBinder;
- private final ManyToOneBinder manyToOneBinder;
- private final OneToOneBinder oneToOneBinder;
- private final ColumnNameForPropertyAndPathFetcher columnNameForPropertyAndPathFetcher;
- private final SimpleValueBinder simpleValueBinder;
private final ComponentUpdater componentUpdater;
private GrailsPropertyBinder grailsPropertyBinder;
public ComponentBinder(
MetadataBuildingContext metadataBuildingContext,
MappingCacheHolder mappingCacheHolder,
- EnumTypeBinder enumTypeBinder,
- CollectionBinder collectionBinder,
- SimpleValueBinder simpleValueBinder,
- OneToOneBinder oneToOneBinder,
- ManyToOneBinder manyToOneBinder,
- ColumnNameForPropertyAndPathFetcher columnNameForPropertyAndPathFetcher,
ComponentUpdater componentUpdater) {
this.metadataBuildingContext = metadataBuildingContext;
this.mappingCacheHolder = mappingCacheHolder;
- this.enumTypeBinder = enumTypeBinder;
- this.collectionBinder = collectionBinder;
- this.simpleValueBinder = simpleValueBinder;
- this.oneToOneBinder = oneToOneBinder;
- this.manyToOneBinder = manyToOneBinder;
- this.columnNameForPropertyAndPathFetcher = columnNameForPropertyAndPathFetcher;
this.componentUpdater = componentUpdater;
}
diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/GrailsDomainBinder.java b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/GrailsDomainBinder.java
index 65d249d151..38b58c384f 100644
--- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/GrailsDomainBinder.java
+++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/GrailsDomainBinder.java
@@ -164,12 +164,6 @@ public class GrailsDomainBinder implements AdditionalMappingContributor, TypeCon
new ComponentBinder(
metadataBuildingContext,
getMappingCacheHolder(),
- enumTypeBinder,
- collectionBinder,
- simpleValueBinder,
- oneToOneBinder,
- manyToOneBinder,
- columnNameForPropertyAndPathFetcher,
componentUpdater);
GrailsPropertyBinder grailsPropertyBinder =
diff --git a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/CollectionBinderSpec.groovy b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/CollectionBinderSpec.groovy
index 50797e3374..b51ef3585c 100644
--- a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/CollectionBinderSpec.groovy
+++ b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/CollectionBinderSpec.groovy
@@ -89,12 +89,6 @@ class CollectionBinderSpec extends HibernateGormDatastoreSpec {
ComponentBinder componentBinder = new ComponentBinder(
metadataBuildingContext,
binder.getMappingCacheHolder(),
- enumTypeBinderToUse,
- collectionBinder,
- simpleValueBinder,
- oneToOneBinder,
- manyToOneBinder,
- columnNameForPropertyAndPathFetcher,
componentUpdater
)
diff --git a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/ComponentBinderSpec.groovy b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/ComponentBinderSpec.groovy
index bdae83a0b4..be10d82802 100644
--- a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/ComponentBinderSpec.groovy
+++ b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/ComponentBinderSpec.groovy
@@ -14,14 +14,8 @@ import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateEmbeddedPro
import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateManyToOneProperty
import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateOneToOneProperty
import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateSimpleProperty
-import org.grails.orm.hibernate.cfg.domainbinding.binder.CollectionBinder
import org.grails.orm.hibernate.cfg.domainbinding.binder.ComponentBinder
import org.grails.orm.hibernate.cfg.domainbinding.binder.ComponentUpdater
-import org.grails.orm.hibernate.cfg.domainbinding.binder.EnumTypeBinder
-import org.grails.orm.hibernate.cfg.domainbinding.binder.OneToOneBinder
-import org.grails.orm.hibernate.cfg.domainbinding.binder.ManyToOneBinder
-import org.grails.orm.hibernate.cfg.domainbinding.binder.SimpleValueBinder
-import org.grails.orm.hibernate.cfg.domainbinding.util.ColumnNameForPropertyAndPathFetcher
import org.grails.orm.hibernate.cfg.domainbinding.collectionType.CollectionHolder
import org.hibernate.mapping.BasicValue
@@ -73,14 +67,8 @@ class ComponentBinderSpec extends HibernateGormDatastoreSpec {
MappingCacheHolder mappingCacheHolder = Mock(MappingCacheHolder)
CollectionHolder collectionHolder
- EnumTypeBinder enumTypeBinder = Mock(EnumTypeBinder)
- CollectionBinder collectionBinder = Mock(CollectionBinder)
PropertyFromValueCreator propertyFromValueCreator = Mock(PropertyFromValueCreator)
- OneToOneBinder oneToOneBinder = Mock(OneToOneBinder)
- ManyToOneBinder manyToOneBinder = Mock(ManyToOneBinder)
- ColumnNameForPropertyAndPathFetcher columnNameFetcher = Mock(ColumnNameForPropertyAndPathFetcher)
ComponentUpdater componentUpdater = Mock(ComponentUpdater)
- SimpleValueBinder mockSimpleValueBinder = Mock(SimpleValueBinder)
org.grails.orm.hibernate.cfg.domainbinding.binder.GrailsPropertyBinder grailsPropertyBinder = Mock(org.grails.orm.hibernate.cfg.domainbinding.binder.GrailsPropertyBinder)
@Subject
@@ -88,16 +76,9 @@ class ComponentBinderSpec extends HibernateGormDatastoreSpec {
def setup() {
def metadataBuildingContext = getGrailsDomainBinder().getMetadataBuildingContext()
- mockSimpleValueBinder = Mock(SimpleValueBinder)
binder = new ComponentBinder(
metadataBuildingContext,
mappingCacheHolder,
- enumTypeBinder,
- collectionBinder,
- mockSimpleValueBinder,
- oneToOneBinder,
- manyToOneBinder,
- columnNameFetcher,
componentUpdater
)
binder.setGrailsPropertyBinder(grailsPropertyBinder)
diff --git a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/GrailsPropertyBinderSpec.groovy b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/GrailsPropertyBinderSpec.groovy
index 795cf6356e..8f1813678f 100644
--- a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/GrailsPropertyBinderSpec.groovy
+++ b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/GrailsPropertyBinderSpec.groovy
@@ -148,12 +148,6 @@ class GrailsPropertyBinderSpec extends HibernateGormDatastoreSpec {
ComponentBinder componentBinder = new ComponentBinder(
metadataBuildingContext,
binder.getMappingCacheHolder(),
- enumTypeBinderToUse,
- collectionBinder,
- simpleValueBinder,
- oneToOneBinder,
- manyToOneBinder,
- columnNameForPropertyAndPathFetcher,
componentUpdater
)
GrailsPropertyBinder propertyBinder = new GrailsPropertyBinder(
diff --git a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/secondpass/ListSecondPassBinderSpec.groovy b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/secondpass/ListSecondPassBinderSpec.groovy
index 884ceeb9ca..059c052a28 100644
--- a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/secondpass/ListSecondPassBinderSpec.groovy
+++ b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/secondpass/ListSecondPassBinderSpec.groovy
@@ -88,12 +88,6 @@ class ListSecondPassBinderSpec extends HibernateGormDatastoreSpec {
ComponentBinder componentBinder = new ComponentBinder(
metadataBuildingContext,
binder.getMappingCacheHolder(),
- enumTypeBinderToUse,
- collectionBinder,
- simpleValueBinder,
- oneToOneBinder,
- manyToOneBinder,
- columnNameForPropertyAndPathFetcher,
componentUpdater
)
diff --git a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/secondpass/MapSecondPassBinderSpec.groovy b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/secondpass/MapSecondPassBinderSpec.groovy
index 61915a4e3e..86f0b4d474 100644
--- a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/secondpass/MapSecondPassBinderSpec.groovy
+++ b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/secondpass/MapSecondPassBinderSpec.groovy
@@ -88,12 +88,6 @@ class MapSecondPassBinderSpec extends HibernateGormDatastoreSpec {
ComponentBinder componentBinder = new ComponentBinder(
metadataBuildingContext,
binder.getMappingCacheHolder(),
- enumTypeBinderToUse,
- collectionBinder,
- simpleValueBinder,
- oneToOneBinder,
- manyToOneBinder,
- columnNameForPropertyAndPathFetcher,
componentUpdater
)