You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/22 02:55:13 UTC
[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request, #1289: nshlib: Disable dmesg if RAMLOG_SYSLOG disabled
no1wudi opened a new pull request, #1289:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1289
## Summary
You can't disable domes if RAMLOG_SYSLOG disabled since `NSH_DISABLE_DMESG` depends on it.
## Impact
dmesg only, minor
## Testing
Custom build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1289: nshlib: Disable dmesg if RAMLOG_SYSLOG disabled
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1289:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1289#discussion_r950987608
##########
nshlib/Kconfig:
##########
@@ -272,8 +272,8 @@ config NSH_DISABLE_DIRNAME
config NSH_DISABLE_DMESG
bool "Disable dmesg"
- default DEFAULT_SMALL
- depends on RAMLOG_SYSLOG
Review Comment:
let's remove RAMLOG_SYSLOG directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1289: nshlib: Disable dmesg if RAMLOG_SYSLOG disabled
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1289:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org