You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by wilderrodrigues <gi...@git.apache.org> on 2016/01/20 14:09:46 UTC

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/846#issuecomment-173198529
  
    Ping @remibergsma @borisroman 
    
    @kishankavala added a unit test to cover his change. I went through the code and haven't found any issue.
    
    The if block ```if(_hostDao.listByType(Host.Type.ExternalFirewall).isEmpty() && _hostDao.listByType(Host.Type.ExternalLoadBalancer).isEmpty()){``` added to ExternalDeviceUsageManagerImpl make sense and are covered.
    
    Please give it a go with the integration tests we have.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---