You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/09 03:46:46 UTC

[GitHub] [kafka] ashwinpankaj commented on pull request #13084: KAFKA-14598: Fix flaky ConnectRestApiTest

ashwinpankaj commented on PR #13084:
URL: https://github.com/apache/kafka/pull/13084#issuecomment-1375070970

   > Is this a change in behavior? It appears that the default mode is LISTEN:
   > 
   > https://github.com/apache/kafka/blob/95910af3a9125c3c67fe5daebf1e01d7ec6f20c7/tests/kafkatest/services/connect.py#L78
   > 
   > and it is only overwritten if the incoming mode is truey:
   > https://github.com/apache/kafka/blob/95910af3a9125c3c67fe5daebf1e01d7ec6f20c7/tests/kafkatest/services/connect.py#L124-L125
   > 
   > It seems like the problem is not that the startup_mode is wrong, but that the STARTUP_MODE_LISTEN is not waiting for all resources to be registered.
   
   Thanks for taking a look @gharris1727 !
   The code which you linked is for ConnectServiceBase.
   ConnectRestApiTest uses [ConnectDistributedService, which overrides startup_mode to STARTUP_MODE_JOIN](https://github.com/apache/kafka/blob/95910af3a9125c3c67fe5daebf1e01d7ec6f20c7/tests/kafkatest/services/connect.py#L376) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org