You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/09 18:39:00 UTC

[jira] [Commented] (KAFKA-8992) Don't expose Errors in `RemoveMemberFromGroupResult`

    [ https://issues.apache.org/jira/browse/KAFKA-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947923#comment-16947923 ] 

ASF GitHub Bot commented on KAFKA-8992:
---------------------------------------

abbccdda commented on pull request #7478: KAFKA-8992: (2.4 blocker) Redefine RemoveMembersFromGroup interface on Admin Client 
URL: https://github.com/apache/kafka/pull/7478
 
 
   Simplify the data struct by leveraging a `KafkaFuture<Map<Member, Errors>>` struct
   rename `getMembers` to `members`
   Avoid exposing errors from result directly
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Don't expose Errors in `RemoveMemberFromGroupResult`
> ----------------------------------------------------
>
>                 Key: KAFKA-8992
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8992
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Boyang Chen
>            Priority: Blocker
>             Fix For: 2.4.0
>
>
> The type `RemoveMemberFromGroupResult` exposes `Errors` from `topLevelError`. We should just get rid of this API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)