[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #11: build: refactor package

[GitBox <gi...@apache.org>]

tzssangglass commented on a change in pull request #11:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/11#discussion_r639646421



##########
File path: runner-dist/src/main/bin/startup.sh
##########
@@ -15,3 +15,15 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
+RUNNER_HOME=$(dirname "$0")/..
+
+RUNNER_HEAP=${JAVA_HEAP:-4g}
+
+JAVA_OPS="${JAVA_OPS} -Xmx${RUNNER_HEAP} -Xms${RUNNER_HEAP}"
+
+nohup java -jar ${JAVA_OPS} ${RUNNER_HOME}/apisxi-runner-start-*.jar \
+ 1>${RUNNER_HOME}/logs/runner.out \
+ 2>${RUNNER_HOME}/logs/runner.err &
+
+echo $! > ./logs/runner.pid

Review comment:
       It would be better to change the name of the `runner` to `java-runner`?
   because in the future there may be go language runners that also output logs in the `/logs` directory




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org