Re: [PR] refactor(configs): Update some default configs and remove some useless configs [incubator-pegasus]

["empiredan (via GitHub)" <gi...@apache.org>]

empiredan commented on code in PR #1877:
URL: https://github.com/apache/incubator-pegasus/pull/1877#discussion_r1481128123


##########
src/replica/replica_stub.cpp:
##########
@@ -242,8 +243,9 @@ DSN_DEFINE_bool(replication,
 DSN_DEFINE_bool(replication,
                 config_sync_disabled,
                 false,
-                "whether to disable replica configuration periodical sync with the meta server");
-DSN_DEFINE_bool(replication, fd_disabled, false, "whether to disable failure detection");
+                "The interval milliseconds of replica server to send replica config-sync "
+                "requests to meta server");

Review Comment:
   ```suggestion
                   "Whether to disable replica server to send replica config-sync "
                   "requests to meta server periodically");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org