[GitHub] [solr] dsmiley commented on a diff in pull request #1208: SOLR-16571: Add java system property to disable config watch

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #1208:
URL: https://github.com/apache/solr/pull/1208#discussion_r1040469355


##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -188,6 +188,7 @@
 public class SolrCore implements SolrInfoBean, Closeable {
 
   public static final String version = "1.0";
+  public static final String DISABLE_ZK_CONFIG_WATCH = "disable.zk.config.watch";

Review Comment:
   I would prefer this be named something like `configSet.core.watch.enable`



##########
solr/core/src/test/org/apache/solr/core/SolrCoreConfigTest.java:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.core;
+
+import org.apache.solr.client.solrj.embedded.JettySolrRunner;
+import org.apache.solr.cloud.AbstractFullDistribZkTestBase;
+import org.junit.Test;
+
+public class SolrCoreConfigTest extends AbstractFullDistribZkTestBase {

Review Comment:
   This test doesn't seem to need to subclass AbstractFullDistribZkTestBase, which is for distributed-search (sharing) testing.  It appears you could use SolrCloudTestCase which is much simpler.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org