[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7603: GEODE-10243: Fail early if old client auth expires

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on code in PR #7603:
URL: https://github.com/apache/geode/pull/7603#discussion_r853453755


##########
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageDispatcher.java:
##########
@@ -533,21 +534,24 @@ private boolean handleAuthenticationExpiredException(AuthenticationExpiredExcept
       throws InterruptedException {
     long reAuthenticateWaitTime =
         getSystemProperty(RE_AUTHENTICATE_WAIT_TIME, DEFAULT_RE_AUTHENTICATE_WAIT_TIME);
+    // for old client, don't wait for re-auth but unregister this proxy completely.
+    if (getProxy().getVersion().isOlderThan(RE_AUTHENTICATION_START_VERSION)) {
+      synchronized (_stopDispatchingLock) {
+        logger.warn(OLD_CLIENT_AUTHENTICATION_EXPIRED);

Review Comment:
   Why is this log message extracted as a constant? We don't seem to do this for any other log messages.



##########
geode-core/src/upgradeTest/java/org/apache/geode/security/AuthExpirationBackwardCompatibleDUnitTest.java:
##########
@@ -366,6 +367,7 @@ public void multiUserCq() throws Exception {
     assertThat(unAuthorizedOps.get("user1")).asList().contains("DATA:READ:region:11");
   }
 
+  @Ignore("does not support this use case")

Review Comment:
   If this test is not supported statically like this then it should be deleted. If the intent is to support his on versions 1.15 or newer see AssertJ `assumeThat` statement to disable based on version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org