You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/25 13:43:12 UTC
[GitHub] [iceberg] saurabhagas opened a new pull request #2149: Made ParquetConversions and its methods publicly accessible(#2148)
saurabhagas opened a new pull request #2149:
URL: https://github.com/apache/iceberg/pull/2149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] saurabhagas commented on pull request #2149: Made ParquetConversions and its methods publicly accessible(#2148)
Posted by GitBox <gi...@apache.org>.
saurabhagas commented on pull request #2149:
URL: https://github.com/apache/iceberg/pull/2149#issuecomment-784853409
@rdblue, can you check this PR and give your final verdict please? If the change isn't acceptable, I'll close the tracking issue as well. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2149: Made ParquetConversions and its methods publicly accessible(#2148)
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2149:
URL: https://github.com/apache/iceberg/pull/2149#issuecomment-767745931
@saurabhagas, why does this need to be public? This is an internal utility class and I don't think that we need to add it to the API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2149: Made ParquetConversions and its methods publicly accessible(#2148)
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2149:
URL: https://github.com/apache/iceberg/pull/2149#issuecomment-785322301
@saurabhagas, I'm not sure there's enough information in the issue to understand why a different method can't be used, or if it is a good idea to expose this. It sounds like you're constructing different schemas and using stats differently, so how much similarity is there? The Parquet values produced by this are specific to Iceberg's object model. If you're building something different from Iceberg then I would say that it makes the most sense for you to have similar code for your use case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] saurabhagas commented on pull request #2149: Made ParquetConversions and its methods publicly accessible(#2148)
Posted by GitBox <gi...@apache.org>.
saurabhagas commented on pull request #2149:
URL: https://github.com/apache/iceberg/pull/2149#issuecomment-780386224
> I'm closing this since there was no reply. Feel free to reopen if you have time to pick it back up.
@rdblue, sorry, this issue fell out of my radar. I had given the reasoning behind this change in the tracking issue: https://github.com/apache/iceberg/issues/2148 (I've edited the description slightly to help the reader). If you're convinced, please reopen the PR and accept the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] saurabhagas commented on pull request #2149: Made ParquetConversions and its methods publicly accessible(#2148)
Posted by GitBox <gi...@apache.org>.
saurabhagas commented on pull request #2149:
URL: https://github.com/apache/iceberg/pull/2149#issuecomment-785624674
Thanks for the reply. Closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] saurabhagas edited a comment on pull request #2149: Made ParquetConversions and its methods publicly accessible(#2148)
Posted by GitBox <gi...@apache.org>.
saurabhagas edited a comment on pull request #2149:
URL: https://github.com/apache/iceberg/pull/2149#issuecomment-780386224
> I'm closing this since there was no reply. Feel free to reopen if you have time to pick it back up.
@rdblue, sorry, this issue fell out of my radar. I had given the reasoning behind this change in the tracking issue: https://github.com/apache/iceberg/issues/2148 (I've edited the description slightly to help the reader). If you're convinced, please reopen the PR and accept the change. Note that, I'm only interest in the class and its `ParquetConversions::fromParquetPrimitive` method, not all the methods in the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed pull request #2149: Made ParquetConversions and its methods publicly accessible(#2148)
Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #2149:
URL: https://github.com/apache/iceberg/pull/2149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2149: Made ParquetConversions and its methods publicly accessible(#2148)
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2149:
URL: https://github.com/apache/iceberg/pull/2149#issuecomment-774380580
I'm closing this since there was no reply. Feel free to reopen if you have time to pick it back up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org